Page MenuHome

Fix build on Xcode 11 clang toolchain (Apple clang version 11.0.0)
AbandonedPublic

Authored by Andrew Pouliot (darknoon) on Jul 29 2019, 8:44 PM.

Details

Summary

I noticed a number of errors similar to this when trying to build with Xcode 11 beta 4:
https://developer.blender.org/P1056

It seems that the issue comes from the Bullet external, but we can fix it here.

Diff Detail

Repository
rB Blender
Branch
fix-xcode-11-build (branched from master)
Build Status
Buildable 4194
Build 4194: arc lint + arc unit

Event Timeline

Brecht Van Lommel (brecht) requested changes to this revision.Jul 30 2019, 12:27 AM

The issue is with clang 8+ on any platform, not specifically Xcode. We could try to make the test detect clang 8+ specifically, but instead I think it's better to just port over the fix from bullet itself:
https://github.com/bulletphysics/bullet3/pull/2232

Just that fix is fine, when we upgrade bullet as a whole it'll remain fixed.

This revision now requires changes to proceed.Jul 30 2019, 12:27 AM

Alternative fix committed.