Fix build on Xcode 11 clang toolchain (Apple clang version 11.0.0)
AbandonedPublic
Actions

Authored by Andrew Pouliot (darknoon) on Jul 29 2019, 8:44 PM.

Details

Reviewers

Arto Kitula (akitula)
Brecht Van Lommel (brecht)

Summary

I noticed a number of errors similar to this when trying to build with Xcode 11 beta 4:
https://developer.blender.org/P1056

It seems that the issue comes from the Bullet external, but we can fix it here.

Diff Detail

Repository

rB Blender

Branch

fix-xcode-11-build (branched from master)

Build Status

Buildable 4194
Build 4194: arc lint + arc unit

Event Timeline

Andrew Pouliot (darknoon) created this revision.Jul 29 2019, 8:44 PM

Harbormaster completed remote builds in B4194: Diff 16658.Jul 29 2019, 8:44 PM

The issue is with clang 8+ on any platform, not specifically Xcode. We could try to make the test detect clang 8+ specifically, but instead I think it's better to just port over the fix from bullet itself:
https://github.com/bulletphysics/bullet3/pull/2232

Just that fix is fine, when we upgrade bullet as a whole it'll remain fixed.

This revision now requires changes to proceed.Jul 30 2019, 12:27 AM

Brecht Van Lommel (brecht) mentioned this in rB922e77036b3b: Fix Bullet build error with Clang 8 and Xcode 11.Aug 12 2019, 3:12 PM

Alternative fix committed.

Revision Contents
Changeset List

			Path	Packages
M			extern/bullet2/CMakeLists.txt (5 lines)

Commit	Tree	Parents	Author	Summary	Date
9f160aae4e91	601ed6c54401	2b8bc1a22ecb	Andrew Pouliot	Fix build on Xcode 11 clang toolchain (Apple clang version 11.0.0) (Show More…)	Jul 29 2019, 8:29 PM

Diff 16658

View Options

extern/bullet2/CMakeLists.txt

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	16658	2b8bc1a		Jul 29 2019, 8:44 PM	★	★

Fix build on Xcode 11 clang toolchain (Apple clang version 11.0.0)AbandonedPublicActions