Page MenuHome

Fix for T62917 Selected edge is now highlighted with black and white overlays
ClosedPublic

Authored by Eitan (EitanSomething) on Tue, Jul 30, 3:16 AM.

Details

Summary

Fixes issue where selected edge doesn't get highlighted when the overlay is set to black or white.
Need help on:

  • Add the fix to dash overlay.

Diff Detail

Repository
rB Blender

Event Timeline

Eitan (EitanSomething) retitled this revision from Fix for T62917 Fixes issue where selected edge doesn't get highlighted when the overlay is set to black or white. Need help on: - Add the fix to dash overlay. to Fix for T62917.Tue, Jul 30, 3:17 AM
Eitan (EitanSomething) edited the summary of this revision. (Show Details)

Note that the dashed outline was the only draw method a long time ago, it may have been kept just to be conservative. If it's a pain to make it work correctly, it could perhaps just get removed.

Nice find!
Overall is good.
Hope you don't mind that I made some minor changes.
Feel free to Commander back the revision ;)

Note that the dashed outline was the only draw method a long time ago, it may have been kept just to be conservative. If it's a pain to make it work correctly, it could perhaps just get removed.

I think I understand what I need to change in terms of glsl files

@Campbell Barton (campbellbarton) getting selecting to work with DASH is too complicated for me to do in a timely fashion, can you do that part

This looks good to fix at least the non-dashed cases, just doesn't fix T62917 entirely.

This revision is now accepted and ready to land.Fri, Aug 2, 4:22 AM
Eitan (EitanSomething) retitled this revision from Fix for T62917 to Fix for T62917 Selected edge is now highlighted with black and white overlays.Fri, Aug 2, 11:41 PM

When will this be committed?

This comment has been deleted.