Page MenuHome

Fix T68322: Shear in Dopesheet causes crash
ClosedPublic

Authored by Sybren A. Stüvel (sybren) on Aug 8 2019, 6:22 PM.

Details

Summary

This fixes T68322: Shear in Dopesheet causes crash.

The Shear transform operator is now only allowed in these space types:

  • 3D View
  • Image Editor
  • Clip Editor

Diff Detail

Repository
rB Blender
Branch
wip-D5440-shear-dope-crash (branched from master)
Build Status
Buildable 4356
Build 4356: arc lint + arc unit

Event Timeline

To prevent the crash, it's fine - however a more general fix would be nice, since the operator requires location data and the action editor's transform data doesn't provide that.

Think this is basically fine, although I'd prefer to swap the check for spaces known not to work.

Graph & node editor for eg aren't included, while this isn't especially useful, there isn't any reason to disable them.

Sybren A. Stüvel (sybren) updated this revision to Diff 16987.
  • Blacklist instead of whitelist space types
Campbell Barton (campbellbarton) added inline comments.
source/blender/editors/transform/transform_ops.c
894

Just checking action is enough, timeline has been removed.

This revision is now accepted and ready to land.Aug 9 2019, 2:51 PM