Page MenuHome

Make EDGE_SHARP more pleasant

Authored by Ofee (oficsu) on Aug 9 2019, 3:57 PM.



Current sharp edge rendering is a little... rude? See screenshot, it's got bad smoothing and contrast center and i think, than this is distracting:

I suggest changing the order of the rendering of the edges so that it looks like this:

(color theme is slightly changed, this is not related to this patch)

Does it probably require more flexible customization functionality in the user interface?

Diff Detail

Event Timeline

Ofee (oficsu) created this revision.Aug 9 2019, 3:57 PM
Ofee (oficsu) created this object with visibility "All Users".

Sorry for the poor quality screenshots. I did not plan to contribute this patch, but some people said that it looked much better, and now I don’t have the opportunity to take a better screenshot

Brecht Van Lommel (brecht) requested changes to this revision.Aug 12 2019, 11:24 AM

Probably such a hardcoded epsilon in the shader will not work well with models at different scales. The solution for this is likely a bit different.

A code review like this should also include screenshots comparing the same view before and after.

This revision now requires changes to proceed.Aug 12 2019, 11:25 AM
Brecht Van Lommel (brecht) changed the visibility from "All Users" to "Public (No Login Required)".Aug 12 2019, 11:26 AM

Yes the offset is wrong. I'm going to commit a better version.