Page MenuHome

Text Editor: Support comment without selection
ClosedPublic

Authored by Valentin (Poulpator) on Aug 9 2019, 7:13 PM.

Details

Summary

Support toggle comment without selection

Address T68062 for comment, indent is already mostly working

Diff Detail

Repository
rB Blender

Event Timeline

Campbell Barton (campbellbarton) requested changes to this revision.EditedAug 9 2019, 8:51 PM

This crashes if you run it on a blank line of text, then try to type something.

source/blender/editors/space_text/text_ops.c
1248

This was wrong, caused undo to fail.

This revision now requires changes to proceed.Aug 9 2019, 8:51 PM
Valentin (Poulpator) marked an inline comment as done.Aug 9 2019, 9:31 PM
Valentin (Poulpator) updated this revision to Diff 17000.

I have updated the diff, but I'm not sure that's enough as I was not able to reproduce the crashes as you said

This revision is now accepted and ready to land.Aug 11 2019, 12:53 PM