Page MenuHome

VSE: tool system integration
Needs RevisionPublic

Authored by Richard Antalik (ISS) on Aug 11 2019, 10:35 PM.

Details

Summary

I have changed cut operator, so it works as a tool - that could be
reviewed.

Sseq->view is used as a mode for tools, nut sure if this is abuse.

Custom select operator is used here as default, but I guess I was tired when I decided that, it's unnecessary - will update that

Diff Detail

Repository
rB Blender
Branch
arcpatch-D5460 (branched from master)
Build Status
Buildable 5069
Build 5069: arc lint + arc unit

Event Timeline

Update to defunct version.
Still no idea why this doesn't work.

  • fix mode enum for sequencer
  • fix keymap inconsistency
  • actually select should be default
  • custom OP has to be used for select

When opening a new sequencer workspace this error shows:

And a minor note:

release/scripts/startup/bl_ui/space_toolsystem_toolbar.py
2174

*_tools_annotate, could also be in SEQUENCER_PREVIEW
All other functions seems to be there to support it.

release/scripts/startup/bl_ui/space_toolsystem_toolbar.py
2174

In my tests it didn't work, but I can try again

release/scripts/startup/bl_ui/space_toolsystem_toolbar.py
2174

If you use ex. the layout workspace and change the 3d view to Sequencer-preview then you can draw when pressing "d", however if you do the same in the Video Editing workspace it doesn't seem to work.

Richard Antalik (ISS) retitled this revision from VSE: tool system integration [WIP] to VSE: tool system integration.Tue, Sep 24, 1:37 PM
Dalai Felinto (dfelinto) requested changes to this revision.Tue, Sep 24, 1:42 PM

Please pay attention to your compiler warnings. They help spot bugs like:

/source/blender/editors/space_sequencer/sequencer_edit.c: In function ‘sequencer_cut_exec’:
/source/blender/editors/space_sequencer/sequencer_edit.c:2206:18: warning: statement with no effect [-Wunused-value]
         cut_side == SEQ_SIDE_BOTH;
         ~~~~~~~~~^~~~~~~~~~~~~~~~
source/blender/editors/space_sequencer/sequencer_edit.c
2206
- cut_side == SEQ_SIDE_BOTH;
+ cut_side = SEQ_SIDE_BOTH;
source/blender/editors/space_sequencer/space_sequencer.c
883

Why the XXX here?

This revision now requires changes to proceed.Tue, Sep 24, 1:42 PM