Page MenuHome

Sculpt: Orco Draw brush
ClosedPublic

Authored by Pablo Dobarro (pablodp606) on Aug 19 2019, 7:02 PM.

Details

Summary

This new brush is similar to the draw brush but it deforms the mesh from the original coordinates. When used with the sharper curve presets it has a much more pleasant crease/cut behavior than any of the other brushes. This is useful for creating cloth wrinkles, stylized hair or hard surface edges.

Diff Detail

Repository
rB Blender

Event Timeline

Brecht Van Lommel (brecht) requested changes to this revision.Aug 20 2019, 6:50 PM

Can we find a better name for this? "Orco" is a really obscure name, and refers more to an implementation detail than how it behaves.

In terms of implementation this seems more like a falloff option than a new brush, preserving the falloff shape better.

source/blender/editors/sculpt_paint/sculpt.c
2626

vd.fno -> NULL

orig_data.no is copied from either vd.no or vd.fno, so it should work for both cases and not try to use the non-original float normal.

This revision now requires changes to proceed.Aug 20 2019, 6:50 PM

@Brecht Van Lommel (brecht) I also don't like the idea of adding new brushes for small tweaks to the implementation like this one. But currently we have some problems with the other approach:

  • This brush won't work with dyntopo, so the brush option will affect the dyntopo geometry updates as well. I'm not sure if that is properly supported
  • Tools are generated from the internal brush tools, so we are going to have two brushes with completely different effects under the same tool.

And sure, we can change the name of the brush if we keep this as a separate tool. Any suggestion?

To me it seems like this new brush creates ridges and valleys in the mesh, so perhaps simply "Ridge and Valley Brush"?

This might be a bit too long of a name though...

We can keep it as a separate tool. Maybe "Draw Sharp"? At least hints that if you want to draw a sharper pattern you might want to try this brush.

Pablo Dobarro (pablodp606) marked an inline comment as done.
  • Rename orco draw to draw sharp
  • Rebase
This revision is now accepted and ready to land.Sep 6 2019, 10:05 PM
This revision was automatically updated to reflect the committed changes.