Page MenuHome

Update Eigen to 3.3.7
ClosedPublic

Authored by Sebastian Parborg (zeddb) on Aug 21 2019, 11:16 AM.

Details

Summary

This is in preparation for the QuadriFlow remesher lib.

Diff Detail

Repository
rB Blender

Event Timeline

This revision is now accepted and ready to land.Aug 21 2019, 11:44 AM
This revision was automatically updated to reflect the committed changes.

It be nice if future updates to /extern were treated as if they were lib updates (which they are) and have the platform teams atleast give these things a look over.

This caused some pretty icky breakage on windows, which I then had to go fix in a rush, it be better if patches this size at-least were checked if it builds on all platforms, if not i'll still be happy to fix it on my platform, but then i'd be able to schedule it a little better rather than having a bunch of people telling me 'master is broken' and having to drop everything I was doing to go deal with this.

cc: @Nathan Letwory (jesterking)

The ideal solution would be to build and test every code review on the buildbot, so this stuff is automated.