Page MenuHome

Functions: Add More than and Equal to option to compare node
Needs ReviewPublic

Authored by Eitan (EitanSomething) on Aug 23 2019, 1:12 AM.

Details

Summary
  • Compare node.
    • Greater Than
    • Equal
    • Not equal

Diff Detail

Event Timeline

Eitan (EitanSomething) retitled this revision from Functions : Add More than and Equal to option to compare node to Functions: Add More than and Equal to option to compare node.Aug 23 2019, 1:16 AM
Jacques Lucke (JacquesLucke) requested changes to this revision.Tue, Aug 27, 3:16 PM
Jacques Lucke (JacquesLucke) added inline comments.
release/scripts/startup/nodes/function_nodes/compare.py
8

It's usually called "greater than".

9

This can just be "equal".

source/blender/functions/functions/comparisons.cpp
24

No need to add the int types because we are not using them yet.

This revision now requires changes to proceed.Tue, Aug 27, 3:16 PM
source/blender/functions/functions/comparisons.cpp
24

Should I remove the int types for Less than

Eitan (EitanSomething) marked an inline comment as not done.Tue, Aug 27, 3:21 PM
source/blender/functions/functions/comparisons.cpp
24

Yes, remove everything with int for now. Thanks.

Eitan (EitanSomething) marked an inline comment as done.Wed, Aug 28, 12:51 AM
Eitan (EitanSomething) updated this revision to Diff 17601.
  • remove int32
  • add not equal option
  • rename functions
Eitan (EitanSomething) edited the summary of this revision. (Show Details)Wed, Aug 28, 12:51 AM
Eitan (EitanSomething) marked 3 inline comments as done.