Some menus items are disabled when not applicable. In the following example, "Revert" is disabled because there is nothing to revert at the moment. You will notice that it properly looks enabled when you are not hovering over it (leftmost image). But when hovering the text becomes bright and the background takes some of the "selected" color (middle image). It isn't becoming even part-way selected so should not use that color nor become brighter. This patch makes it look like the right-most image:
I have no super strong opinion on this change, but TBH I don’t see the point of this - we already dim the selected menu item if it's disabled. This change seems very slight and also somewhat arbitrarily different.
Actually, I’m going to abandon this, just for now.
Right now this seems a little silly and arbitrary because the use case is so small. But has to get done right when we see this more often - when we get dynamic enable/disable of Edit menu items. Will talk to Brecht and see if I can get that worked out first.