Page MenuHome

UI: Disabled Menu Items
ClosedPublic

Authored by Harley Acheson (harley) on Aug 24 2019, 2:36 AM.

Details

Summary

Some menus items are disabled when not applicable. In the following example, "Revert" is disabled because there is nothing to revert at the moment. You will notice that it properly looks enabled when you are not hovering over it (leftmost image). But when hovering the text becomes bright and the background takes some of the "selected" color (middle image). It isn't becoming even part-way selected so should not use that color nor become brighter. This patch makes it look like the right-most image:

Diff Detail

Repository
rB Blender

Event Timeline

I have no super strong opinion on this change, but TBH I don’t see the point of this - we already dim the selected menu item if it's disabled. This change seems very slight and also somewhat arbitrarily different.

I'd like to keep the text dim when you hover, it's a good change, but the background is bluish as it is now.

Actually, I’m going to abandon this, just for now.

Right now this seems a little silly and arbitrary because the use case is so small. But has to get done right when we see this more often - when we get dynamic enable/disable of Edit menu items. Will talk to Brecht and see if I can get that worked out first.

Currently, disabled menu item on hover looks more like an enabled. I don't see any reason why we shouldn't fix this now.

It’ll be fixed soon. It’s just the need will be more apparent and will be nicer to tweak once we have more. So looking at this now...

https://developer.blender.org/D4846

It’ll be fixed soon. It’s just the need will be more apparent and will be nicer to tweak once we have more. So looking at this now...

https://developer.blender.org/D4846

Reopened this patch after discussions with William

This revision is now accepted and ready to land.Aug 25 2019, 8:45 PM

Keeping the text dimmed is important, so this is a nice change. Approved.

This revision was automatically updated to reflect the committed changes.