Page MenuHome

Cycles: Fix Architecture logging on x64.
ClosedPublic

Authored by LazyDodo (LazyDodo) on Sun, Aug 25, 3:38 AM.

Details

Summary

x64 builds with WITH_CYCLES_OPTIMIZED_KERNEL_SSE2 not defined
since sse2 is the lower bar for x64 cpus. Turning the architecture
logging related if into the last if in the architecture detection
chain, which will never execute unless you turn off all kernels
in de debug flags.

Left a comment, not sure if it was needed or not.

Diff Detail

Repository
rB Blender

Event Timeline

LazyDodo (LazyDodo) planned changes to this revision.Mon, Aug 26, 12:45 AM

Something else is still wrong, still getting 'default kernels' even though it shouldn't be.

I0825 16:43:49.158412 28124 blender_python.cpp:851] Debug flags set to:
CPU flags:
  AVX2       : False
  AVX        : True
  SSE4.1     : False
  SSE3       : True
  SSE2       : False
  BVH layout : BVH8
  Split      : False
CUDA flags:
 Adaptive Compile: False
OpenCL flags:
  Device type    : ALL
  Debug          : False
  Memory limit   : 0
I0825 16:43:49.159389 28124 util_task.cpp:329] Creating pool of 8 threads.
I0825 16:43:49.162317 28124 util_task.cpp:241] Detected 8 processors in active group.
I0825 16:43:49.163295 28124 util_task.cpp:251] Not setting thread group affinity.
I0825 16:43:49.164271 28124 device_cpu.cpp:123] Will be using default kernels.
LazyDodo (LazyDodo) requested review of this revision.Mon, Aug 26, 3:05 PM

Scratch that, it does work, but the debug flags are some counter intuitive stuff, for the SSE3 kernel to load both the SSE2 and SSE3 debug flags need to be on.

This revision is now accepted and ready to land.Mon, Aug 26, 3:11 PM
This revision was automatically updated to reflect the committed changes.