Page MenuHome

UI: File Browser Icon for Unsupported Documents
AbandonedPublic

Authored by Harley Acheson (harley) on Fri, Sep 6, 5:11 PM.

Details

Summary

The updated File Browser large icons (prvicons) contains a new icon meant for documents that Blender does not directly support. This patch makes it use that large document image for any time a document would not have an overlaid "type" icon.

As shown below, for types SVG and BVH. Of course later if we add overlays to either of those they would then get the regular document image.

Diff Detail

Repository
rB Blender

Event Timeline

This is nice, although for SVG and BHV the irony is that we can actually import those in Blender, but that's a separate thing really. We probably should add more supported file types then.

This revision is now accepted and ready to land.Fri, Sep 6, 5:13 PM
Brecht Van Lommel (brecht) requested changes to this revision.EditedFri, Sep 6, 7:03 PM

I'm not sure this is an improvement.

If the file browser is opened with filtering for some file extension enabled, which is most of the time, then I don't think it makes sense to show that file type as "unsupported".

If you are browsing with filtering disabled, that's probably because you need some file extension that is unsupported, and then it doesn't help to deemphasize those files either.

This revision now requires changes to proceed.Fri, Sep 6, 7:03 PM

@Brecht Van Lommel (brecht) - I'm not sure this is an improvement.

Actually I had the same concerns when this new icon was proposed; I am just the gopher in this case and will defer to others.

If it were up to me I think I would show almost everything with the same large "Document" icon regardless if it is something we directly support. So some obscure and unsupported image format would still show as Document and with the overlay icon indicating it is an image type. It saves having to update UI code every time a format is supported. But also allow for addons to deal with things we don't know about. And leaves it in the user's domain to select whatever they want, even if silly. Filtering should be used to show only supported, but unfiltered should show all and be as informative as possible. Just my two cents.

One of the issues in Blender I think, is that wee have many file types which are grey areas. They may not be supported by the built-in enabled IO addons, but can be enabled or supported via external addons. So it's not super clear which file types technically *are* supported or not.

I'm also not really on-board with this change. How would add-ons registered their supported file type?

One of the issues in Blender I think, is that wee have many file types which are grey areas. They may not be supported by the built-in enabled IO addons, but can be enabled or supported via external addons. So it's not super clear which file types technically *are* supported or not.

I guess I don't understand which problem this is intended to solve, what showing a file as "unsupported" is intended to communicate that filtering doesn't already.

If the file browser is opened in a context where some add-on may load that file, then I would expect filtering for the relevant file types to happen. For example if we supported Import... without specifying a file type in advance, I'd expect we filter by all file extensions of all importers.

William Reynish (billreynish) requested changes to this revision.Fri, Sep 6, 9:46 PM

Right - agree to drop this. Let's focus on other improvements.