Page MenuHome

Fix T69663: 2.81 Cant open/append/link a blend file but 2.8 can
ClosedPublic

Authored by Philipp Oeser (lichtwerk) on Mon, Sep 9, 11:12 AM.

Details

Summary

Was a problem in the versioning code from rBbaaa89a0bc54, since the
TexMapping struct could already be freed and node->storage could already
be set to NULL, we have to check for this?

Diff Detail

Repository
rB Blender

Event Timeline

Why would the TexMapping struct be freed? Previously, the mapping info was stored in this struct, so after library linking, this should never be null.

According to @Marcus Papathoma (machieb) , the file was saved in rB4c4a8bf588c5, the new mapping node was already in this build. So the check for the subversion if (!MAIN_VERSION_ATLEAST(bmain, 281, 8)) { is probably the root of the issue. I will debug the build info in the attached file and get back to you.

Looks like the file from the report was saved in (2, 80, 75), if I save it again today, we are on (2, 81, 8)

hmm, ok. I still think the bug is somewhere else, I don't see how node->storage could be null in this case.

hmm, ok. I still think the bug is somewhere else, I don't see how node->storage could be null in this case.

See comment in T69663 for how this can happen

Looks good, but add a comment explaining why this happens.

This revision is now accepted and ready to land.Mon, Sep 9, 2:43 PM