Page MenuHome

Fix crash in dynamic mesh preview edge list update
ClosedPublic

Authored by Pablo Dobarro (pablodp606) on Sep 17 2019, 4:37 PM.

Details

Diff Detail

Repository
rB Blender

Event Timeline

Jeroen Bakker (jbakker) requested changes to this revision.Sep 18 2019, 8:54 AM
Jeroen Bakker (jbakker) added inline comments.
source/blender/editors/sculpt_paint/sculpt.c
9119

If I understand the code correctly we can only support on average 2 lines per vertex, Some might have less, other have more.

When assuming a mesh is triangulated the realistic average per vertex is 6 connected lines. So in the worst case we now only draw 2/3 of all the edges.

As an edge is only drawn once sculpt_vertex_count_get(ss) * 3 * 2 would be more realistic.

This revision now requires changes to proceed.Sep 18 2019, 8:54 AM
Pablo Dobarro (pablodp606) marked an inline comment as done.
  • Review update
Jeroen Bakker (jbakker) requested changes to this revision.Sep 20 2019, 11:42 AM
Jeroen Bakker (jbakker) added inline comments.
source/blender/editors/sculpt_paint/sculpt.c
9119

Add a note so it is clear for other developers where this originates from

we should make it a const int.

This revision now requires changes to proceed.Sep 20 2019, 11:42 AM
Pablo Dobarro (pablodp606) marked an inline comment as done.
  • Rebase
  • Add comment and const
This revision is now accepted and ready to land.Tue, Sep 24, 8:25 AM