Page MenuHome

Fix T69910: Crash when using a hotkey for a New file template or Open Recent file
ClosedPublic

Authored by Pedro Reis (veryprofessionaldodo) on Sep 18 2019, 2:03 PM.

Details

Summary

Hi there, this is my first contribution to Blender, so I apologize before hand if something isn't correct!

This was caused by the tooltip clear being called when a there was no window in the wm property of the Context.

Tested it by replicating the same behaviour as described in the task, and using Blender normally after that. The output of all actions done were expected behaviour, no crashes.

Hope this fixes the problem! :)

Diff Detail

Repository
rB Blender

Event Timeline

Hi @Pedro Reis (veryprofessionaldodo) and thx for the contribution!
Check looks good to me, but I will add other reviews to confirm...

Also style-wise, please use brackets [this should be caught by running make format in the blender directory, I guess]

Oh sorry, thought the formatter of VS Code did that. I'll add the brackets in a bit, going to lunch now

Added brackets to conform to code style guidelines

@Philipp Oeser (lichtwerk) Quick question, how do I assign a Maniphest Task to a revision? I added a new contribution to a different revision, but I don't know how to associate an existing task. Sorry for bothering with such a trivial question :)

EDIT: Nevermind, found it!

@Philipp Oeser (lichtwerk) Are there more reviewers who can review this? It looks like a simple fix, and I feel like there's not much that could go wrong with this tweak :)

@Pedro Reis (veryprofessionaldodo): not sure, I'd just poke the reviewers already here again :)
[relating the fix: there might just be a better place to prevent this earlier, so no other possible future bugs will get hidden by this...]

@Philipp Oeser (lichtwerk) Humm, hadn't considered that, but it does make a lot of sense. At least I hope it might point someone in the right direction!

This revision is now accepted and ready to land.Fri, Oct 4, 4:57 PM

Thank YOU! It's always awesome to help, hope I can add more to Blender in the future! <3