Page MenuHome

Add a responsive schedule to the Blender Conference website
Needs RevisionPublic

Authored by Sem Mulder (SemMulder) on Fri, Sep 27, 12:18 PM.

Details

Summary

Also includes two minor bugfixes:

  • a missing noop migration
  • and missing <p> tags.

Diff Detail

Repository
rBCONF Blender Conference
Branch
bcon19-schedule-flexbox
Build Status
Buildable 5123
Build 5123: arc lint + arc unit

Event Timeline

Sybren A. Stüvel (sybren) requested changes to this revision.Tue, Oct 1, 12:41 PM
Sybren A. Stüvel (sybren) added inline comments.
conference_main/models.py
63

Would an enum be suitable here? Or would that be over-engineering things?

196

I would remove the else: clause here. When the if-statement is switch-like I see the visual clarity of having all the return statements at the same indentiation. However, here it's just a precondition check, and the indent IMO is unnecessary.

conference_main/templates/conference_main/schedule.pug
41

This is a UX design choice. Personally I wouldn't mind if the favourite button would always be shown, and give some "You should be logged in for this to work" message when the user is anonymous. That would make this feature easier to discover; I'm guessing most visitors will not log in unless they know they have a reason to.

conference_main/views/event.py
3

Why the two separate import statements?

111

Don't use not user.is_anonymous, use user.is_authenticated instead.

113

This could also be implemented as a function for_user(user.pk) -> QuerySet on a custom ModelManager for the Event class. Or maybe a favorited_by(user.pk) -> bool function.

204

If you move this line below the next, you can use something like:

ctx['events_unscheduled_count'] = len(events) - len(scheduled_events)

and avoid double iteration.

221

Same as above

This revision now requires changes to proceed.Tue, Oct 1, 12:41 PM