Page MenuHome

Sculpt/Paint: Dash Ratio and Dash Samples
ClosedPublic

Authored by Pablo Dobarro (pablodp606) on Sep 30 2019, 6:30 PM.
Tags
None
Subscribers
None
Tokens
"Love" token, awarded by BalderAgnarsson."Love" token, awarded by monio."Love" token, awarded by Brandon777."Love" token, awarded by JulienKaspar."Love" token, awarded by wilBr."Love" token, awarded by n-pigeon."Love" token, awarded by tiagoffcruz."Love" token, awarded by franMarz."Love" token, awarded by MetinSeven."Love" token, awarded by Alrob."100" token, awarded by Frozen_Death_Knight."Love" token, awarded by lopoIsaac.

Details

Summary

Dash Ratio and Dash Samples are brush parameters to modify the strength of the brush during a stroke. This is useful to create dashed lines in texture paint or stitches in sculpt mode.

Diff Detail

Repository
rB Blender

Event Timeline

  • Disable step instead of set strength to 0

I think doing this should not affect any tool that uses spacing/line/curve

release/scripts/startup/bl_ui/space_view3d_toolbar.py
972

Perhaps set this to false and in stead of col.row just use row?

979

Same here

source/blender/blenloader/intern/versioning_280.c
3935

Can't we check if dash_ratio/dash_samples are new, can lead to future unwanted behavior

source/blender/editors/sculpt_paint/paint_stroke.c
489

When is dash_samples 0?

Jeroen Bakker (jbakker) requested changes to this revision.Nov 14 2019, 10:46 AM
This revision now requires changes to proceed.Nov 14 2019, 10:46 AM
Pablo Dobarro (pablodp606) marked 3 inline comments as done.
  • Review Update
source/blender/blenloader/intern/versioning_280.c
3935

Is there other way to check this different than checking if the values are initialized to incorrect defaults?

Jeroen Bakker (jbakker) requested changes to this revision.Nov 15 2019, 3:42 PM
Jeroen Bakker (jbakker) added inline comments.
source/blender/blenloader/intern/versioning_280.c
3935

DNA_struct_elem_find can check if the input file was saved using a blend version with a known specific DNA field.

eg
!DNA_struct_elem_find(fd->filesdna, "Brush", "float", "dash_ratio")

This revision now requires changes to proceed.Nov 15 2019, 3:42 PM
Pablo Dobarro (pablodp606) marked an inline comment as done.
  • Update Versioning
  • Rebase
Jeroen Bakker (jbakker) requested changes to this revision.Nov 18 2019, 2:47 PM
Jeroen Bakker (jbakker) added inline comments.
source/blender/blenloader/intern/versioning_280.c
3950

Merge together with previous if statement. both exist or don't exist there is no way that one exist without the other.

This revision now requires changes to proceed.Nov 18 2019, 2:47 PM
Pablo Dobarro (pablodp606) marked an inline comment as done.
  • Fix versioning code
This revision is now accepted and ready to land.Nov 19 2019, 12:59 PM