Page MenuHome

Theme: NLA Channel and Track
ClosedPublic

Authored by Paul (Thirio) on Wed, Oct 2, 10:58 AM.

Details

Summary

Existing dopesheet_channel added to the theme editor.
And a new nla_track color added to separate the color from the theme space header.

Issue seen on: Theme Development - Paper Cuts

Diff Detail

Repository
rB Blender

Event Timeline

Paul (Thirio) created this revision.Wed, Oct 2, 10:58 AM
Paul (Thirio) edited the summary of this revision. (Show Details)Wed, Oct 2, 11:03 AM
Brecht Van Lommel (brecht) requested changes to this revision.Wed, Oct 2, 12:03 PM

The new nla_track color needs to be initialized for existing preferences in do_versions_theme in versioning_userdef.c.

Something like:

copy_v4_v4_uchar(btheme->space_nla.nla_track, btheme->space_nla.header);
release/datafiles/userdef/userdef_default_theme.c
588

Set alpha to 1, even if not used now: 0x424242ff

This revision now requires changes to proceed.Wed, Oct 2, 12:03 PM
Paul (Thirio) edited the summary of this revision. (Show Details)

Thanks, Brecht! I've added the initialization for existing preferences under

/**
 * Include next version bump.
 */

And set the alpha of the new color to 1.

This revision is now accepted and ready to land.Wed, Oct 2, 3:10 PM