Page MenuHome

GPU: show more descriptive labels on unsupported GPU dialog
ClosedPublic

Authored by Brecht Van Lommel (brecht) on Tue, Oct 8, 7:31 PM.

Details

Summary

@LazyDodo (LazyDodo), I'm having some trouble getting this to build since TASKDIALOGCONFIG
is missing, even if it is supposed to be in commctrl.h.

I believe this happens because we are not building with a new enough Windows SDK
version or something, but I couldn't easily find how to fix this.

Fixes T70521

Diff Detail

Repository
rB Blender

Event Timeline

LazyDodo (LazyDodo) added a comment.EditedTue, Oct 8, 7:45 PM

near the top of GHOST_SystemWin32.cpp , it changes the target version back to XP, just remove it, it's being set correctly in platform_win32.cmake

#define _WIN32_WINNT 0x501
  • small build fixes

There were some other linker shenanigans, builds now, but it didn't seem to give me a warn on mesa/llvm pipe on windows, so i didn't actually see the dialog.

manually added it to the blacklist, dialog seems to work!

This revision was not accepted when it landed; it landed in state Needs Review.Wed, Oct 9, 1:43 PM
This revision was automatically updated to reflect the committed changes.