Page MenuHome

Fix T69644 / T68586: objects flag unsynced when drag hidden collections

Authored by Dalai Felinto (dfelinto) on Thu, Oct 10, 9:34 PM.

Diff Detail

rB Blender

Event Timeline

@Brecht Van Lommel (brecht) this solution scream "wrong" to me all over it. It bothers me to have to run sync twice, but if I were to create a _shallow sync function or any similar hack I'm afraid we would be adding too much extra hassle in the code, that could easily get out of sync from the main functions. Any 2 cents?

@Sebastian Parborg (zeddb) could you try (before and after) this in a production computer with production scenes, to see if it got too bad in real life?

@Dalai Felinto (dfelinto) how thorough do you want this testing to be? Just a simple subjective test or what?

@Sebastian Parborg (zeddb) if it pass a subjective test, then it is good. If it doesn't than numbers would help base our decision here.

We tested moving and toggling hiding/disabling on a production scene and we could not subjectively notice any difference.

This revision is now accepted and ready to land.Mon, Oct 14, 2:19 PM

Yes sorry, it should be a _not_ in there. (Updated my comment)