Details

Reviewers

Maniphest Tasks

T67025: Viewport Clipping Not Visible in Wireframe Mode
T70512: Viewport clipping ALT+B in lookedv, rendered displays some data clipped, some not...

Commits

rB7878adf49cff: DrawManager: Disable Clipping in material/rendered mode

Summary

Viewport: Disable Clipping For EEVEE and External Renderers

Currently it is possible that, when using viewport clipping, the display and tools communicate
different information to the user then the renderer does. The reason is
that the renderer does not support viewport clipping. Both EEVEE and
Cycles do not support it.

This patch will disable the clipping in all the tools and drawing code
when the viewport drawing mode is Material Preview or Rendered.

This patch introduces a RV3D_CLIPPING_ENABLED util that checks if
clipping is enabled for the given rv3d and v3d. Also in places where
it was needed we added the ViewContext as a carrier for the View3D
and RegionView3D.

There are a few areas in the tooling (select, projection painting) that
still needs to be tackled after this patch.

Diff Detail

Repository

rB Blender

Branch

T70512 (branched from master)

Build Status

Buildable 5328
Build 5328: arc lint + arc unit

Event Timeline

Jeroen Bakker (jbakker) created this revision.Oct 11 2019, 7:04 AM

Harbormaster completed remote builds in B5328: Diff 18949.Oct 11 2019, 7:04 AM

Jeroen Bakker (jbakker) retitled this revision from Do now show viewport clipping when in material or rendered mode to [WIP] Do now show viewport clipping when in material or rendered mode.Oct 11 2019, 7:04 AM

Moved code to DNA_view_types as a define

Harbormaster completed remote builds in B5329: Diff 18950.Oct 11 2019, 9:51 AM

CLang

Harbormaster completed remote builds in B5330: Diff 18951.Oct 11 2019, 9:53 AM

Adding clip border to determine if we need to show the clipping

Harbormaster completed remote builds in B5331: Diff 18952.Oct 11 2019, 10:02 AM

Jeroen Bakker (jbakker) retitled this revision from [WIP] Do now show viewport clipping when in material or rendered mode to DrawManager: Disable Clipping in material/rendered mode.Oct 11 2019, 10:05 AM

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)

Jeroen Bakker (jbakker) added a reviewer: Clément Foucault (fclem).

Jeroen Bakker (jbakker) added a project: GPU / Viewport.

Jeroen Bakker (jbakker) added a task: T67025: Viewport Clipping Not Visible in Wireframe Mode.Oct 17 2019, 4:33 PM

Redo with new unified overlays

Migrated to new overlay engine

Harbormaster completed remote builds in B5955: Diff 20185.Tue, Dec 10, 3:53 PM

In previous diff I missed one file I wanted to revert. This diff reverts that file

Harbormaster completed remote builds in B5956: Diff 20186.Tue, Dec 10, 3:55 PM

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)Tue, Dec 10, 4:00 PM

Clément Foucault (fclem) accepted this revision.Wed, Dec 11, 1:04 PM

Clément Foucault (fclem) added inline comments.

source/blender/draw/engines/workbench/workbench_data.c
133	is that ok during rendering?

This revision is now accepted and ready to land.Wed, Dec 11, 1:04 PM

Jeroen Bakker (jbakker) marked an inline comment as done.Wed, Dec 11, 4:53 PM

Jeroen Bakker (jbakker) added inline comments.

source/blender/draw/engines/workbench/workbench_data.c
133	Yes, `RV3D_CLIPPING_ENABLED` does the NULL checks.

Closed by commit rB7878adf49cff: DrawManager: Disable Clipping in material/rendered mode (authored by Jeroen Bakker (jbakker)). · Explain WhyWed, Dec 11, 4:58 PM

This revision was automatically updated to reflect the committed changes.

Jeroen Bakker (jbakker) marked an inline comment as done.

Jeroen Bakker (jbakker) added a commit: rB7878adf49cff: DrawManager: Disable Clipping in material/rendered mode.

			Path	Packages
M			source/blender/draw/engines/workbench/workbench_data.c (4 lines)
M			source/blender/draw/engines/workbench/workbench_deferred.c (2 lines)
M			source/blender/draw/engines/workbench/workbench_forward.c (2 lines)
M			source/blender/draw/intern/DRW_render.h (1 line)
M			source/blender/draw/intern/draw_manager.c (13 lines)
M			source/blender/draw/intern/draw_manager_text.c (5 lines)
M			source/blender/draw/modes/edit_curve_mode.c (8 lines)
M			source/blender/draw/modes/edit_lattice_mode.c (4 lines)
M			source/blender/draw/modes/edit_mesh_mode.c (28 lines)
M			source/blender/draw/modes/overlay_mode.c (4 lines)
M			source/blender/draw/modes/paint_vertex_mode.c (12 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	18949	f9cc517		Oct 11 2019, 7:04 AM	★	★
Diff 2	18950	f9cc517	Moved code to DNA_view_types as a define	Oct 11 2019, 9:51 AM	★	★
Diff 3	18951	f9cc517	CLang	Oct 11 2019, 9:53 AM	★	★
Diff 4	18952	f9cc517	Adding clip border to determine if we need to show the clipping	Oct 11 2019, 10:02 AM	★	★
Diff 5	20185	96a1bc2	Migrated to new overlay engine	Tue, Dec 10, 3:53 PM	★	★
Diff 6	20186	96a1bc2	In previous diff I missed one file I wanted to revert. This diff reverts that…	Tue, Dec 10, 3:55 PM	★	★
Diff 7	20217	61e0e93	rB7878adf49cfff6ccbb18203f21c6355a518b34db	Wed, Dec 11, 4:58 PM	★	★

DrawManager: Disable Clipping in material/rendered mode
ClosedPublic
Actions

Details

Diff Detail

Event Timeline

Revision Contents
Changeset List

Diff 18949

source/blender/draw/engines/workbench/workbench_data.c

source/blender/draw/engines/workbench/workbench_deferred.c

source/blender/draw/engines/workbench/workbench_forward.c

source/blender/draw/intern/DRW_render.h

source/blender/draw/intern/draw_manager.c

source/blender/draw/intern/draw_manager_text.c

source/blender/draw/modes/edit_curve_mode.c

source/blender/draw/modes/edit_lattice_mode.c

source/blender/draw/modes/edit_mesh_mode.c

source/blender/draw/modes/overlay_mode.c

source/blender/draw/modes/paint_vertex_mode.c

DrawManager: Disable Clipping in material/rendered modeClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 18949

source/blender/draw/engines/workbench/workbench_data.c

source/blender/draw/engines/workbench/workbench_deferred.c

source/blender/draw/engines/workbench/workbench_forward.c

source/blender/draw/intern/DRW_render.h

source/blender/draw/intern/draw_manager.c

source/blender/draw/intern/draw_manager_text.c

source/blender/draw/modes/edit_curve_mode.c

source/blender/draw/modes/edit_lattice_mode.c

source/blender/draw/modes/edit_mesh_mode.c

source/blender/draw/modes/overlay_mode.c

source/blender/draw/modes/paint_vertex_mode.c

DrawManager: Disable Clipping in material/rendered mode
ClosedPublic
Actions

Revision Contents
Changeset List