Page MenuHome

Fix T70740: Clicking on proxy bone makes original one jump to initial location
ClosedPublic

Authored by Sergey Sharybin (sergey) on Oct 11 2019, 4:34 PM.

Details

Summary

Caused by what appears to be a missing flush from evaluated bone back to
original, which then makes it so copy-on-write operation happening after
click (to synchronize selection flags) pushes original bone to its initial
position.

Diff Detail

Repository
rB Blender

Event Timeline

Don’t see anything wrong here, besides the interrogation about removed call to BKE_pose_channel_free_bbone_cache() noted below…

source/blender/blenkernel/intern/armature_update.c
743

Already present in master, so not directly related to that patch, but… can someone explain me that name? Or is it supposed to be BKE_pose_copyresult_pchan_result() or something? Or maybe BKE_pose_copy_pchan_result() ? Would need some cleanup for sure. ;)

755–757

That part is removed in the changes, is it actually useless then?

This revision is now accepted and ready to land.Oct 11 2019, 6:08 PM
Sergey Sharybin (sergey) planned changes to this revision.Oct 11 2019, 6:56 PM

Good catch about the bbone cache. Need to doublecheck that it behaves correct for both cases.

However, not really sure why is it depsgraph evaluation which clears the bbone cache in original. But probably i'd just restore old behavion in this patch and investigate why cache clear is needed afterwards.

Or maybe @Alexander Gavrilov (angavrilov) remembers why it was added? :)

Restored bbone cache clear.
Still not sure why it's done here, but investigation of it can happen
outside of this patch.

This revision is now accepted and ready to land.Oct 14 2019, 11:12 AM