Page MenuHome

Fix T69921: VSE - Waveforms unnecessary redrawn on offset change
ClosedPublic

Authored by Richard Antalik (ISS) on Oct 13 2019, 4:19 AM.

Details

Summary

Waveform is freed in sound_load_audio() when sound length is queried by BKE_sound_info_get().

Add argument free_waveform, so BKE_sound_info_get() can skip waveform freeing, as it is not expected to alter sound.

Diff Detail

Repository
rB Blender

Event Timeline

Probably is fine, but totally deserved more explanation about what exactly is causing the issue.

Richard Antalik (ISS) edited the summary of this revision. (Show Details)Oct 16 2019, 2:56 AM

Probably is fine, but totally deserved more explanation about what exactly is causing the issue.

added description

Apart from the inline-mentioned comment, LGTM.

source/blender/blenkernel/intern/sound.c
1101–1103

This could use a comment to explain why this doesn't cause a memory leak. And maybe also document the reason why memory shouldn't be freed here, as it's not instantly obvious.

Richard Antalik (ISS) marked an inline comment as done.
  • Add comment
This revision was not accepted when it landed; it landed in state Needs Review.Wed, Jan 22, 1:38 PM
This revision was automatically updated to reflect the committed changes.