Page MenuHome

Fix T69636: Crash when rendering scene srtip.
AbandonedPublic

Authored by Richard Antalik (ISS) on Oct 13 2019, 3:11 PM.

Details

Summary

Add filter for scene UI template to avoid setting VSE scene as source for strip.

Diff Detail

Repository
rB Blender
Branch
arcpatch-D6054 (branched from master)
Build Status
Buildable 5362
Build 5362: arc lint + arc unit

Event Timeline

There is also task T66461: Sequencer: Scene strips cameras from all scenes can be selected
I am not quite sure how to solve that. It would be nice to filter in context of some arbitrary data (or list of data) provided by argument, so I could filter all cameras of provided scene. I guess I could implement that, but I would like to hear feedback.

Campbell Barton (campbellbarton) requested changes to this revision.EditedOct 14 2019, 9:54 AM

We should be able to use the pointer poll function here.

See: rna_Curve_otherObject_poll for example.

This way it doesn't rely on the layout code to enforce this rule.


Correction PROP_ID_SELF_CHECK is a better choice in this case.

This revision now requires changes to proceed.Oct 14 2019, 9:54 AM
  • Revert "Fix T69636: Crash when rendering scene srtip."
  • Use poll function to filter scenes

@Campbell Barton (campbellbarton) I am not sure if T69636: Crash when rendering in VSE is even valid then, because you can choose camera "from another scene" even in properties editor as source for rendering.
I guess I could look up available camera in collection? But not sure if collection is filled by depsgraph or why it isn't available during handling RNA.

Abandon in favor of D6073