Page MenuHome

Fix T62882: Make Dynamic Paint update weights in viewport
ClosedPublic

Authored by Nico Zevallos (gnastacast) on Oct 15 2019, 6:44 PM.

Details

Summary

Related to T62882
When the SupportsMapping modifier flag was added 3fab39f to the dynamic paint modifier it was added commented out. It may have not worked back then, but it seems to work fine now.
MOD_weightvgedit.c was updated similarly in 2c5a919

Interestingly all of the weight editing modifiers (MOD_weightvgmix.c MOD_weightvgproximity.c MOD_weightvg_util.c) also have the eModifierTypeFlag_SupportsEditmode tag as well, even though toggling the option in the UI doesn't do anything in edit mode (The modifier always affects edit mode.) I am wondering if I should add the same tag to MOD_dynamicpaint.c so that it behaves in the same way.

Diff Detail

Repository
rB Blender

Event Timeline

Nico Zevallos (gnastacast) retitled this revision from Make Dynamic Paint update weights in viewport to Fix T62882: Make Dynamic Paint update weights in viewport.Oct 16 2019, 4:02 PM

Not really my area. If it works just commit i guess? :)

Can confirm that this works, although it would be more useful if weights could be overlayed outside of weight paint mode

This revision is now accepted and ready to land.Nov 27 2019, 1:24 PM