Page MenuHome

VSE: Proxy Panel Clean Up
Needs ReviewPublic

Authored by Peter Fog (tintwotin) on Oct 16 2019, 11:08 AM.

Details

Summary

The current proxy panel is mixing functions which will work on active strip and selected strips, and this makes the panel(s) more confusing. And also leave all elements active while Custom File should make them inactive.

Before:

The main idea behind the design suggestion is to move active strip related proxy functions into the Strip tab and let the Proxies for Selected Strips stay in the Proxies & Cache tab.

After - Active Strip:

After - Active Strip - Custom File toggle:

After - Selected Strips:

I realized that using Custom File needs to disable except the Resolutions, because the selected resolution will only enable the Custom file, when Viewed in that selected Resolution. This is a huge part of what imo causes a lot of confusion in this panel - that buttons are used differently depending on what else is selected(same thing with the Rebuild Proxy in the old layout).

Make Build Proxy button inactive when no resolutions are selected.

In order to keep consistency for functions related to the active strip are in the Strip tab, the Strip Cache functions has been moved here too.

Several Effect panels where below the Adjust panel, ex. Scene, Text, Multicam Strips they are now above the Adjust panel, like the more general Effect strips.

The proxy building entry in the Strip Menu has been renamed to "Rebuild Selected Strips Proxies" so it is in consistency with the panel.

Diff Detail

Event Timeline

Minor fixes concerning active states when no strips are in the Sequencer.

Peter Fog (tintwotin) edited the summary of this revision. (Show Details)Oct 17 2019, 3:44 PM
Peter Fog (tintwotin) edited the summary of this revision. (Show Details)

The main 3 proxy functions: Setup, Build and View could also be collected in a nifty "quick" menu like this:


(But this is not implemented in the patch, since the proxy view sub menu doesn't seem to affect the actual selection, and someone would have to help me with getting that to work)

Peter Fog (tintwotin) updated this revision to Diff 19119.EditedOct 19 2019, 8:22 AM
Peter Fog (tintwotin) retitled this revision from VSE: Proxy Panel Clean Up. to VSE: Proxy Panel Clean Up.
Peter Fog (tintwotin) edited the summary of this revision. (Show Details)

I realized that using Custom File needs to disable everything except the Resolutions, because the selected resolution will only enable the Custom file, when Viewed in that selected Resolution.

This is a huge part of what imo causes a lot of confusion in this panel - that buttons are used differently depending on what else is selected(same thing with the Rebuild Proxy in the old layout).

So this is after Custom File has been selected:

And Custom File has been removed from the Selected Strips Panel:

Peter Fog (tintwotin) edited the summary of this revision. (Show Details)Oct 19 2019, 8:25 AM
Peter Fog (tintwotin) edited the summary of this revision. (Show Details)

Make Build Proxy button inactive when no resolutions are selected.

Use enabled instead of active, to limit interaction with non active widgets.

when my Delete proxy patch is committed will you add delete proxy to the panel

Peter Fog (tintwotin) added a comment.EditedSun, Dec 8, 8:57 AM

Looking more closely at this panel, one of the things I realize is that it is not possible to render proxies if non of the selected strips has a check mark in the Strip Proxy header. So in order to separate render proxy for active strip vs. all selected strips, would need a checkmark in the header of the selected strips header to add a check mark to all selected strips. And the Proxy and Timeline tabs isn't only for generating proxies, but also by the checkmark deside what strips should be viewed with proxies, or in other words you won't see the encoded proxy files by selecting their resolution in the Preview/View panel, you would also have to add a checkmark to all strips...

I think I'll have to conclude after attempting to simplify the proxy UI, that the proxy panel and proxy generation really needs a general redesign and rethinking - the mess of what relates to active vs. selected strips in the panel in combination with actually selecting what proxy files to view in a different panel, is simply too confusing and not very intuitive.

In order to simplify it, the proxy encoding settings could be moved into Preferences. And in the Sequencer UI there should only be a proxy resolution selector(25%, 50%, 75%, 100%, No Proxy), which upon selection automatic would encode proxies in the chosen resolution(if missing) of all strips(maybe using Richard's cool on-strip-encoding-progress-bars patch?). This is not something I'll be able do, since I do not code C.

Anyway, maybe @William Reynish (billreynish) can make a proper design suggestion on how to simplify the use of VSE proxies and I can close this patch?