Page MenuHome

Allow deletion of directories in the file browser

Authored by Robert Guetzkow (rjg) on Oct 16 2019, 9:23 PM.



This diff allows to delete directories in the file browser. The commit did not include this feature.

Diff Detail

rB Blender
file-browser-delete-dir (branched from master)
Build Status
Buildable 5396
Build 5396: arc lint + arc unit

Event Timeline

I thought this feature would require far more changes, but if I'm not mistaken the current diff is all that is needed. BLI_make_file_string seems to cover the need for canonical path creation for directories as well. I've made some basic tests on Linux and Windows and haven't encountered any problems so far.

Robert Guetzkow (rjg) retitled this revision from Allow to delete directories in the file browser to Allow deletion of directories in the file browser.Oct 19 2019, 4:11 PM

Bump because of the limited time frame for 2.81 otherwise it'll be in 2.82. Technically it's not a bug and more of an absent feature, but it would be weird to leave that functionality out.

@Julian Eisel (Severin) Is there anything that needs further improvements?

Tested this a bit ago and it worked fine. I could spend some time to do more testing to be sure, but I think it's better to just push this and see if anybody is having any trouble. In worst case we can revert, it's a small code change.

This revision is now accepted and ready to land.Thu, Nov 21, 5:42 PM

@Julian Eisel (Severin) Could you commit this for me? I don't have commit rights.