Page MenuHome

Fix T58842: Add-ons Import/Export entries disapear when enabling Filter Addons option
Changes PlannedPublic

Authored by Philipp Oeser (lichtwerk) on Oct 17 2019, 11:52 AM.

Details

Summary

Implemented in rBd937d06c02f6, rB61c8ed40f5df, the workspace Addon
filtering was missing actually (force)adding the Import-Export Addons
when the filter was enabled.

This will make sure Import-Export Addons are never filtered away, but
still not expose them to the UI list.

sidenote: maybe we should mention this in the "Filter Addons" tooltip?
(the fact that Import-Export Addons are always there...)

2nd sidenote: not sure we should rename "tags" throughout the code here
as well? Or is it planned to have this support anything else than Addon
filtering? See "WorkSpace UI Tags", "Filter the UI by tags", "UI Tags",
"Use UI Tags", "Remove all tags", "Remove ui tag", "Add ui tag", "New
name for the tag", "Tag to remove"...

Diff Detail

Repository
rB Blender
Branch
T58842_ (branched from master)
Build Status
Buildable 5402
Build 5402: arc lint + arc unit

Event Timeline

In general we should avoid initializing data in drawing code, it's too prone to errors when the draw code doesn't run.

You may install an import/export add-on after setting the filter.

Think this use_owner option feature from rB61c8ed40f5df897da212b55dadeee252c8d3997b isn't going to work well unless we have a way to initialize it when addons are enabled and when switching workspaces.

It's probably simpler to remove this feature and have a way for import/export menus to bypass this filtering option.

Philipp Oeser (lichtwerk) planned changes to this revision.Mon, Oct 28, 3:10 PM

Didnt find a way to initialize this on addon enable, looking into doing the bypass for import/export menus instead...