Page MenuHome

Fix T70905: Image Editor header hides mask, cache and keyframe info if flipped to bottom
ClosedPublic

Authored by Philipp Oeser (lichtwerk) on Oct 17 2019, 10:40 PM.

Details

Summary

While flipping the header to bottom works in the MCE (because MCE doesnt
allow overlapping UI) we need to take the regions visible rect into
account for the Image Editor.

Diff Detail

Repository
rB Blender

Event Timeline

Sergey Sharybin (sergey) requested changes to this revision.Oct 18 2019, 9:10 AM
Sergey Sharybin (sergey) added inline comments.
source/blender/editors/include/ED_screen.h
407

Why to remove const? Is this because some underlying functions don't get const pointer? Would prefer to add const to those.

source/blender/editors/mask/mask_draw.c
806

Comment is a full sentence, starting with capital letter and ending with a fullstop.

source/blender/editors/screen/area.c
3342

Same as above.

3383

Same as above.

source/blender/editors/space_image/image_draw.c
904

Same as above.

This revision now requires changes to proceed.Oct 18 2019, 9:10 AM
Philipp Oeser (lichtwerk) marked 4 inline comments as done.Oct 18 2019, 12:36 PM
Philipp Oeser (lichtwerk) added inline comments.
source/blender/editors/include/ED_screen.h
407

Yes, this was because both ED_region_cache_draw_background and ED_region_cache_draw_cached_segments would now use ED_region_visible_rect.

"Constifying" ED_region_visible_rect is not possible afaict (it alters ar->runtime.visible_rect)

Alternative: let callers of ED_region_cache_draw_background and ED_region_cache_draw_cached_segments calculate region_bottom prior (call ED_region_visible_rect prior) and pass that in? (doesnt look pretty either...)

Just noticed that we also need to adjust the clickable "scrubbing area" [atm. this isnt scrubbable if the header is flipped to the bottom]

  • correct clickable scubbing area (poll for frame_change) in the Image Editor when header is flipped to bottom
  • correct clickable scubbing area (poll for frame_change) in the Image Editor and the MovieClip Editor not taking UI_DPI_FAC into account
This revision was not accepted when it landed; it landed in state Needs Review.Tue, Oct 29, 5:20 PM
This revision was automatically updated to reflect the committed changes.