Page MenuHome

GPencil: Primitive: Polyline Tool
ClosedPublic

Authored by Charlie Jolly (charlie) on Oct 18 2019, 10:38 PM.

Diff Detail

Repository
rB Blender

Event Timeline

Antonio Vazquez (antoniov) added inline comments.
source/blender/editors/gpencil/gpencil_primitive.c
434

Is really working the Wheel? I use the wheel but the number doesn't change (at least in the UI)

1352

Remove this line.

1708

Do we have control points for this new polyline? I don't see anything..is it a bug or not?

release/scripts/presets/keyconfig/keymap_data/blender_default.py
5805

Do we need Shift and Alt keymaps?

Charlie Jolly (charlie) marked 3 inline comments as done.

Fix comments

Charlie Jolly (charlie) marked an inline comment as done.

Missed comment

Charlie Jolly (charlie) marked an inline comment as not done.Oct 18 2019, 11:20 PM
Charlie Jolly (charlie) added inline comments.
release/scripts/presets/keyconfig/keymap_data/blender_default.py
5805

Shift yes but not alt

Add back mousewheel support to increase number of points per line
Add back control point to show last pivot point

This revision is now accepted and ready to land.Oct 18 2019, 11:40 PM

We have not implemented the F and Shift+F keys in this primitive and to be consistent with other primitives we need both.

Add back FKEY for brush size

Matias Mendiola (mendio) requested changes to this revision.Oct 19 2019, 1:20 PM

We have not implemented the F and Shift+F keys in this primitive and to be consistent with other primitives we need both.

The ESC key to cancel is missing too

This revision now requires changes to proceed.Oct 19 2019, 1:20 PM

Add back ESC key to cancel

This revision is now accepted and ready to land.Oct 19 2019, 1:34 PM
This revision was automatically updated to reflect the committed changes.

For me all is fine now and you can commit to master.