Page MenuHome

VSE: Expose existing Select Channel Both(directions) operator in Menu
AbandonedPublic

Authored by Peter Fog (tintwotin) on Oct 21 2019, 9:45 AM.

Details

Summary

@Alessio Monti di Sopra (a.monti) found this unexposed operator, which allows for selecting all strips in the channel of the active strip - in both directions.

This patch exposes it in menu as Select > Channel > Both.

Diff Detail

Event Timeline

Add missing space around =

Have you tried, if this would work? I think, that it works when invoked by keyboard and resolve mouse position to channel you want to select.

It works fine through the menu(gif):

Ah sorry, I see now

This revision is now accepted and ready to land.Oct 21 2019, 10:07 PM

@Richard Antalik (ISS) I don't have commit rights. Could you commit this, if everything is okay?

Campbell Barton (campbellbarton) requested changes to this revision.Oct 25 2019, 11:45 AM

Selecting an entire channel seems like something that would be better accessed without accessing menu items.

Why not make clicking on the numbers on the left hand side - select all items in the channel?

Setting as requesting changes because this seems a slow & awkward way of selecting an entire channel.

This revision now requires changes to proceed.Oct 25 2019, 11:45 AM

At this time and with the lack of VSE dev manpower in mind, adding this very useful function to the Menu is the simplest possible way to do it and it will allow users to assign a short-cut.

Of course moving channel tools into the sequencer area would be nice, but clicking channel numbers, might be impossible in some cases:

And on top of this I fear it wouldn't be an understandable option for users, unless channel selection is implemented as proper channel headers(as known from the NLA or most other NLEs out there(mockup)):

So in other words, considering everything, it is better for users to have access to the full channel selection from now(surprisingly it has been implemented years ago, but never exposed), and when/if channel headers are implemented it should be removed from the menu.

@Peter Fog (tintwotin), we could try and find a good solution, this isn't necessarily that much work, it could even be a good entry level paper-cut task.

Great, if we can find a better solution and even better if we can find a C coder to implement it. I have a list of 'VSE Quick Hacks in C', which really should be listed here at Phabricator. I'll put it on that list, but until a better solution is found, please consider committing this patch which exposes an already implemented feature in a way which is in consistency with the other selection operators.

Here's the list: https://docs.google.com/document/d/1HhStCHVVID6UOwl36caZU6twZ12yXeNCPoX0n3gik6s/edit