Page MenuHome

UI: Incorrect Cursor Used in Split Area Operator
ClosedPublic

Authored by Harley Acheson (harley) on Oct 23 2019, 11:26 PM.

Details

Summary

A number of operations can be made on an area when right-clicking on a gap between editors and selecting from the context menu. "Horizontal Split" uses the incorrect cursor, the same one used for vertical split.

Note that this problem does not occur when splitting using the corner action zones, as these two operations differ. This only happens when using the edge context menus. The vertical split cursor is correct, while the horizontal split cursor is incorrect:

This is caused by a confusion between two different variables. "gesture_dir" is used sometimes to indicate a direction and will contain "n, s, e, w". While "direction" only contains "v" or "h". The code in question wrongly assumed that "direction" contained 'n, s, e, w' and so it's test for 'n' or 's' was always false.

Diff Detail

Repository
rB Blender