Page MenuHome

Cleanup: Windows Manifest usage.
Needs ReviewPublic

Authored by LazyDodo (LazyDodo) on Sun, Oct 27, 1:19 AM.



We had a manifest file, but it was seemingly not used, some settings were done using linker pargmas, some of them visual studio would set by default for us, others where not set at all.

This patch changes:

  1. Single manifest file where we can maintain all settings in a single location, removal of any linker pragmas
  1. Compatibly settings for win vista - win10, without this any call to any of the GetVersion and related functions (GetVersionEx, VerifyVersionInfo, IsWindowsXxxx) will by default say we are on vista and OS specific optimizations in external shared libraries may be missed.
  1. Rather than having it in the RC file in an #ifdef which may or may not trigger depending on the build tool used, we tell cmake to treat it as a source file and it will do the right thing for both the ninja and visual studio generators.

Diff Detail

rB Blender
tmp_manifest_cleanup (branched from master)
Build Status
Buildable 5461
Build 5461: arc lint + arc unit

Event Timeline

@Brecht Van Lommel (brecht) Out of curiosity is 2 the reason you ended up importing RtlGetVersion in cycles?