Page MenuHome

Fix T68018: Crash on building movie proxy
ClosedPublic

Authored by Richard Antalik (ISS) on Tue, Oct 29, 5:37 AM.

Details

Summary

Crash happens, when setting custom dir to location of source file itself.
This results in attempt to create directory with the same name as source file.

Fix works in VSE, aditional fixes may be needed in other editors.

Diff Detail

Repository
rB Blender

Event Timeline

Campbell Barton (campbellbarton) added inline comments.
source/blender/editors/space_sequencer/sequencer_edit.c
180

Can pass ReportList instead of reports.

Richard Antalik (ISS) marked an inline comment as done.
  • Pass ReportList instead of wmOperator

If it fixes the issue go ahead.

This revision is now accepted and ready to land.Wed, Oct 30, 10:28 AM
This revision was automatically updated to reflect the committed changes.

I have build error:
/var/tmp/portage/media-gfx/blender-2.81.9999/work/blender-2.81.9999/source/blender/blenkernel/intern/sequencer.c: In function ‘BKE_sequencer_proxy_rebuild_context’:
/var/tmp/portage/media-gfx/blender-2.81.9999/work/blender-2.81.9999/source/blender/blenkernel/intern/sequencer.c:2110:5: error: ‘return’ with no value, in function returning non-void [-Werror=return-type]

bartus sz (bartus) added inline comments.
source/blender/blenkernel/intern/sequencer.c
2110

gcc-9 complains about error: ‘return’ with no value, in function returning non-void [-Werror=return-type]
It should return with false/true