Page MenuHome

Pose brush: Smooth Iterations Brush Property
AcceptedPublic

Authored by Pablo Dobarro (pablodp606) on Wed, Oct 30, 5:32 PM.
Subscribers
None
Tokens
"Doubloon" token, awarded by TheAngerSpecialist."Love" token, awarded by MetinSeven."Like" token, awarded by Alrob."Love" token, awarded by Frozen_Death_Knight."Like" token, awarded by TheRedWaxPolice."Love" token, awarded by Brandon777.

Details

Summary

The smooth iterations of the pose factor were hardcoded to 4. This works fine in most situations when you are posing a low poly mesh, which is the main use case of this tool. I added the smooth iterations as a brush property in case you need to pose a high poly mesh directly without producing artifacts.

Diff Detail

Repository
rB Blender
Branch
pose-smooth-iterations (branched from master)
Build Status
Buildable 5704
Build 5704: arc lint + arc unit

Event Timeline

Jeroen Bakker (jbakker) requested changes to this revision.Thu, Nov 14, 3:19 PM

Note I didn't see any migration code for existing curves. Is this needed?

source/blender/editors/sculpt_paint/sculpt.c
5267–5272

Where does the 1.5f come from. Please add comment

5267–5272

Use float not integers when the rest is a float. Compilers might add an additional not needed conversion.

This revision now requires changes to proceed.Thu, Nov 14, 3:19 PM
Pablo Dobarro (pablodp606) edited the summary of this revision. (Show Details)
  • Review update, Add versioning code
Pablo Dobarro (pablodp606) marked 2 inline comments as done.Thu, Nov 14, 7:53 PM

The current way of dealing with the PBVH nodes is not the best, but I will improve it after finishing the patch for the pose brush with inverse kinematics, which needs to store multiple pose factors per vertex at the same time.

Jeroen Bakker (jbakker) requested changes to this revision.Fri, Nov 15, 3:56 PM
Jeroen Bakker (jbakker) added inline comments.
source/blender/blenloader/intern/versioning_280.c
3935

cann't we use DNA_struct_elem_find ?

This revision now requires changes to proceed.Fri, Nov 15, 3:56 PM
Pablo Dobarro (pablodp606) marked an inline comment as done.
  • Update versioning
This revision is now accepted and ready to land.Mon, Nov 18, 2:46 PM