Differential D6172

Windows: Replace deprecated SHGetFolderPathW
ClosedPublic
Actions

Authored by Germano Cavalcante (mano-wii) on Nov 1 2019, 5:55 PM.

Tags

None

Subscribers

LazyDodo (LazyDodo)

Details

Reviewers

LazyDodo (LazyDodo)

Group Reviewers

Platform: Windows

Commits

rBaf9f4f43ce21: Windows: Replace deprecated SHGetFolderPathW
rB89e2a8f17aa1: Windows: Replace deprecated SHGetFolderPathW

Summary

It has no functional change, but since I saw that SHGetFolderPathW
is deprecated, it might be a good idea to replace.

Diff Detail

Repository

Branch

master

Build Status

Buildable 5526
Build 5526: arc lint + arc unit

Event Timeline

Germano Cavalcante (mano-wii) created this revision.Nov 1 2019, 5:55 PM

Harbormaster completed remote builds in B5526: Diff 19331.Nov 1 2019, 5:55 PM

Germano Cavalcante (mano-wii) added a reviewer: Platform: Windows.Nov 1 2019, 5:56 PM

Beyond some minor cleanup lgtm

intern/ghost/intern/GHOST_SystemPathsWin32.h
32	This is done in platform_win32.cmake , these two lines can be removed ,

This revision is now accepted and ready to land.Nov 1 2019, 6:06 PM

Clenaup: Remove unnecessary lines

Harbormaster completed remote builds in B5527: Diff 19332.Nov 1 2019, 6:21 PM

Closed by commit rB89e2a8f17aa1: Windows: Replace deprecated SHGetFolderPathW (authored by Germano Cavalcante (mano-wii)). · Explain WhyNov 1 2019, 6:23 PM

This revision was automatically updated to reflect the committed changes.

Germano Cavalcante (mano-wii) added a commit: rB89e2a8f17aa1: Windows: Replace deprecated SHGetFolderPathW.

Germano Cavalcante (mano-wii) added a commit: rBaf9f4f43ce21: Windows: Replace deprecated SHGetFolderPathW.Mon, Nov 11, 6:26 PM

Revision Contents
Changeset List

			Path	Packages
M			intern/ghost/intern/GHOST_SystemPathsWin32.h (2 lines)
M			intern/ghost/intern/GHOST_SystemPathsWin32.cpp (17 lines)

Diff 19331

intern/ghost/intern/GHOST_SystemPathsWin32.h

Loading...

intern/ghost/intern/GHOST_SystemPathsWin32.cpp

Loading...