Page MenuHome

Sculpt: Multiplane Scrape Brush
AcceptedPublic

Authored by Pablo Dobarro (pablodp606) on Sat, Nov 2, 5:21 PM.
Tokens
"Mountain of Wealth" token, awarded by TheAngerSpecialist."Like" token, awarded by hitrpr."Love" token, awarded by jayrajkharvadi."Love" token, awarded by franMarz."Love" token, awarded by linko."Love" token, awarded by billreynish."Like" token, awarded by amonpaike."Love" token, awarded by plyczkowski."Love" token, awarded by Maged_afra."Love" token, awarded by n-pigeon."Burninate" token, awarded by Zino."Love" token, awarded by juantxo."Love" token, awarded by MetinSeven."100" token, awarded by Frozen_Death_Knight."Mountain of Wealth" token, awarded by Brandon777."Love" token, awarded by RodDavis."Love" token, awarded by shakesoda."Love" token, awarded by xrg.

Details

Summary

The Multiplane Scrape brush creates sharp edges with a given fixed angle by trimming the mesh with two planes in local space at the same time. When working with stylized or hard surface models, this brush produces way better results and is more predictable than any other crease/flatten brush based on curves and alphas.
It is also the first brush we have than can produce hard surface concave creases.

The Multiplane Scrape Brush also has a dynamic mode where it samples the surface to fit the angle and scrape planes during a stroke. With this mode enabled you can sculpt multiple times over the same edge without creating artifacts.

It can also create creases that change between concave and convex during the same stroke.

The behavior of this brush will improve after merging patches like D5993 and its behavior in concave creases can still be improved, so I will keep tweaking its parameters and default values once we have all brush properties available.

Diff Detail

Repository
rB Blender
Branch
sculpt-multiplane-scrape (branched from master)
Build Status
Buildable 5584
Build 5584: arc lint + arc unit

Event Timeline

Pablo Dobarro (pablodp606) edited the summary of this revision. (Show Details)
  • Small tweaks to dynamic mode
Jeroen Bakker (jbakker) requested changes to this revision.Tue, Nov 5, 12:41 PM

Just some minor tweaks needed, rest seems fine

source/blender/blenkernel/intern/brush.c
937

Merge with line above

source/blender/editors/sculpt_paint/sculpt.c
1768

use floats

4853

0.0f

4854

isn't this the same as an absolute?

5045

if (flip)?

source/blender/makesdna/DNA_brush_types.h
337

Seems like you added 8 chars. These can be removed.

449

} eBrushFlags2;

best to add it, so we can use it as types.

source/blender/makesrna/intern/rna_brush.c
2027

show_multiplane_scrape_planes_preview

This revision now requires changes to proceed.Tue, Nov 5, 12:41 PM
Pablo Dobarro (pablodp606) marked 7 inline comments as done.
  • Review update
Jeroen Bakker (jbakker) requested changes to this revision.Wed, Nov 6, 12:46 PM
Jeroen Bakker (jbakker) added inline comments.
source/blender/makesrna/intern/rna_brush.c
86

Seems like one comment I wasn't committed last time.

use clang-format off/on around rna_enum_brush_sculpt_tool_items so formatting is better readable.

This revision now requires changes to proceed.Wed, Nov 6, 12:46 PM
Pablo Dobarro (pablodp606) marked an inline comment as done.
  • Rebase, review update
This revision is now accepted and ready to land.Mon, Nov 11, 11:58 AM