Page MenuHome

VSE: add Adjust Last Operation panel to the video sequencer
Needs ReviewPublic

Authored by Alessio Monti di Sopra (a.monti) on Thu, Nov 7, 6:44 PM.

Details

Summary

The patch adds the adjust last operation panel to the Video Sequencer and makes some little changes to the operators.

Removed OPTYPE_REGISTER from the following operators, in order to avoid showing them in the redo panel:

  • select
  • select_all
  • select_inverse
  • select_box
  • strip_jump

Hidden some properties for the same reason:

  • modifier_move
  • modifier_remove
  • set_range_to_strips

Removed an unused transform mode property from SEQUENCER_OT_duplicate.

A couple of changes in effect_strip_add:

  • avoid throwing an error when tweaking the start and end frame of the strip (set end frame to [start frame + 1] if lower than the start frame).
  • set the soft min/max of start and end frame to 0/MAXFRAME
  • changed the color property to use an actual color socket instead of a generic array


There might be others, but I only noticed this as a major problem at the moment: this gets called by Move/Extend from Playhead but the redo doesn't work properly, the moment you tweak the values it always behaves as if you were moving the whole strip instead of only a handle.


I noticed similar errors in the Graph editor and the Nla with the equivalent functions.
I saw you were the last one touching this code @Germano Cavalcante (mano-wii) and found this task T68836, do you think this is something likely to be solved by your work in this area?

Diff Detail

Repository
rB Blender

Event Timeline

I noticed similar errors in the Graph editor and the Nla with the equivalent functions.
I saw you were the last one touching this code @Germano (Germano) Cavalcante (mano-wii) and found this task T68836, do you think this is something likely to be solved by your work in this area?

Some problems with transform operations are known and will be resolved after the refactor.
As soon as I have time I will update some patches and give progress to this refactor.

If the problem is not reported, it would be good to make one so we can keep track of it.

I noticed similar errors in the Graph editor and the Nla with the equivalent functions.
I saw you were the last one touching this code @Germano (Germano) Cavalcante (mano-wii) and found this task T68836, do you think this is something likely to be solved by your work in this area?

Some problems with transform operations are known and will be resolved after the refactor.
As soon as I have time I will update some patches and give progress to this refactor.
If the problem is not reported, it would be good to make one so we can keep track of it.

Thanks, I'll check the bug tracker and report the problems if they are not already there.

I just quickly skimmed over this. Seems OK, just please check when adding new region, if any versioning code is needed, so older files can use this feature.

I just quickly skimmed over this. Seems OK, just please check when adding new region, if any versioning code is needed, so older files can use this feature.

I've checked with both 2.79 and 2.80 files and it seems to work fine, the region gets enabled by default.

I just noticed that the problem exists in reverse, if you saved a file with the patch applied and the redo panel open at save time, and then open that file in 2.80, this happens:


It goes away if you change frame (I guess because it doesn't have a redo option) or if you perform an operation in another editor.

Nb. All effect strips gets a color button, but it doesn't seem to be connected to anything. Ex. the color button isn't related to the color of the text or color strips and even multicam gets a color button.