Page MenuHome

Fix T71461: Add IN_PLACE_INSTANCES to `part_prim` and `part_axis` object mode particle shaders
ClosedPublic

Authored by Kevin Buhr (buhr) on Nov 10 2019, 9:49 PM.

Details

Summary

For Particle Properties -> Viewport Display -> Display As set to to circle/cross/axis, particle instances are associated with a single resource handle (and, in particular, a single model matrix) , so define IN_PLACE_INSTANCES to get the right index for ModelMatrix and ModelInverseMatrix in the shader.

Diff Detail

Repository
rB Blender

Event Timeline

source/blender/draw/modes/object_mode.c
519

style : break the line like this

"#define IN_PLACE_INSTANCES\n"
"#define USE_AXIS\n"

@Clément Foucault (fclem) is it good otherwise? Asking so someone else can commit this to 2.81 once addressed (or even address if patch contributor takes too long to reply).

And importantly, is this safe for 2.81? (does it pass EEVEE tests?)

This revision is now accepted and ready to land.Nov 11 2019, 5:05 PM

Hi @Kevin Buhr (buhr) we usually would wait for the patch contributor to go over a few iterations to get the patch final and ready. This way you get to see more of the process and over time the patches can get bigger and more complex.

This time exceptionally @Germano Cavalcante (mano-wii) went ahead and addressed the changes himself, because we are very close to the final window for changes in 2.81, and the sooner the patch gets in, the more test it gets.

Thanks for your contribution.