Page MenuHome

Sculpt: Clay Thumb Brush
Needs ReviewPublic

Authored by Pablo Dobarro (pablodp606) on Tue, Nov 12, 11:24 PM.
Tokens
"Love" token, awarded by christianclavet."Yellow Medal" token, awarded by threedslider."Love" token, awarded by ThomasJohann."Love" token, awarded by ofuscado."Love" token, awarded by brilliant_ape."Love" token, awarded by andruxa696."Love" token, awarded by RodDavis."Love" token, awarded by TheFlow."Burninate" token, awarded by Alrob."Love" token, awarded by franMarz."100" token, awarded by Frozen_Death_Knight."Love" token, awarded by xrg."Love" token, awarded by tiagoffcruz."Love" token, awarded by Brandon777.

Details

Summary

This brush simulates deforming clay with your fingers, accumulating
material during the stroke. It has a plane that tilts during the stroke
in the front part of the brush to achieve this effect.
This brush needs at least 10 input samples in order to work properly.

Diff Detail

Repository
rB Blender
Branch
sculpt-clay-thumb (branched from master)
Build Status
Buildable 5665
Build 5665: arc lint + arc unit

Event Timeline

Dalai Felinto (dfelinto) added inline comments.
source/blender/editors/sculpt_paint/sculpt.c
5062

Could we have any comment explaining what this function is doing, and the whys?
The comments can be populated throughout the code after an initial overall big picture.

5107

Suggestion: const float tilt_mix = local_co[1] > 0.0f ? 0.0f : 1.0f;

5136

Same here. This function is the core function of the brush and is severely under commented.

5145

Please follow code style for comments (Starts with a capital letter, ends with a period)

Pablo Dobarro (pablodp606) marked 4 inline comments as done.
  • Add comments, review update