Page MenuHome

Fix T71554: 'Hide Unselected' not working for certain face selection
ClosedPublic

Authored by Philipp Oeser (lichtwerk) on Thu, Nov 14, 12:33 PM.

Details

Summary

rBc6cbcf83d015 caused to early out when not all faces were selected (but
surrounding faces were, so implicitly all vertices were selected). Now
take face selection mode into account.

Diff Detail

Repository
rB Blender

Event Timeline

Wouldn't this need an edge check as well? For this case? (white edge is not selected)

correct case for edges as well

Sorry, I really hate to be "that guy" commenting over the shoulder, but, looking at the logic, I think these cases are still not handled (i.e. it'll bail too early):

"All faces" selected, but one (or more) edges aren't:


"All edges" selected, but one (or more) verts aren't:

"All faces" selected, but one (or more) verts aren't:

...and etc. with all three selection modes active.

Philipp Oeser (lichtwerk) planned changes to this revision.Fri, Nov 15, 9:45 AM

Sorry, I really hate to be "that guy" commenting over the shoulder, but, looking at the logic, I think these cases are still not handled (i.e. it'll bail too early):
"All faces" selected, but one (or more) edges aren't:


"All edges" selected, but one (or more) verts aren't:

"All faces" selected, but one (or more) verts aren't:

...and etc. with all three selection modes active.

To me, having the "that guy" commenting over the shoulder is actually the strength of OSS [ this way we catch issues early on :) ]
Will check again if the logic in EDBM_mesh_hide will actually handle your cases well (or if we'd need changes there, too...)

If the implementation hasn't changed since 2.79, it should, as these cases work there.

Since modes can be mixed, the order of these checks should be reversed and converted to else if.

fix mixed selection mode

This revision is now accepted and ready to land.Tue, Nov 19, 9:28 AM