Differential D6258

Revert "Fix T68380 Skin modifier root not displayed"
AbandonedPublic
Actions

Authored by Dalai Felinto (dfelinto) on Thu, Nov 14, 10:34 PM.

Details

Reviewers

None

Group Reviewers

User Interface

Summary

This reverts commit 4ddf3215a7df3ac4a0cfceccb283414510078ba5.

Fix T70991 - File Explorer: Maximize window no the filename textbox on Windows

Note, although this fix the immediate obvious issue there are still some
things that need fixing in this file browser.

For instance, now (or before this commit) Blender stores the maximized
window size but not its state. So if you re-open the file browser after
maximizing it, the window will be very big although not "maximized".

Also the file browser is always opened in the top edge of the window,
regardless of where it was moved to last time (unlike the console window
or the view render for example).

So we should decide and be consistent. We either NEVER save either
parameter, or save them all.

Diff Detail

Repository

rB Blender

Branch

fix-T70991-filebrowser-windows-maximize-wrong-style (branched from master)

Build Status

Buildable 5687
Build 5687: arc lint + arc unit

Event Timeline

Dalai Felinto (dfelinto) created this revision.Thu, Nov 14, 10:34 PM

Harbormaster completed remote builds in B5687: Diff 19642.Thu, Nov 14, 10:34 PM

I did the arc diff for the wrong base branch, let me try again.

Dalai Felinto (dfelinto) removed a task: T70991: Blender File Explorer: maximize window wont show the file name text box on WIndows.Thu, Nov 14, 10:46 PM

Revision Contents
Changeset List

		Path
M		intern/ghost/intern/GHOST_WindowWin32.cpp (2 lines)
M		source/blender/draw/CMakeLists.txt (1 line)
M		source/blender/draw/intern/draw_cache_extract.h (5 lines)
M		source/blender/draw/intern/draw_cache_extract_mesh.c (65 lines)
M		source/blender/draw/intern/draw_cache_impl.h (1 line)
M		source/blender/draw/intern/draw_cache_impl_mesh.c (19 lines)
M		source/blender/draw/intern/draw_common.h (1 line)
M		source/blender/draw/intern/draw_common.c (1 line)
M		source/blender/draw/modes/edit_mesh_mode.c (37 lines)
M		source/blender/draw/modes/shaders/common_globals_lib.glsl (1 line)
D	M	source/blender/draw/modes/shaders/edit_mesh_skin_root_vert.glsl (30 lines)

Commit	Tree	Parents	Author	Summary	Date
76fac0f2ada0	d2ae5f153858	59af27ede2b4	Dalai Felinto	Fix T70991 - File Explorer: Maximize window no the filename textbox on Windows (Show More…)	Thu, Nov 14, 10:27 PM
59af27ede2b4	f9f187a95c5c	c25a910e4ec0	Dalai Felinto	Revert "Fix T68380 Skin modifier root not displayed" (Show More…)	Thu, Nov 14, 9:06 PM