Page MenuHome

Improve error message converting nurb to bezier
Needs ReviewPublic

Authored by Philipp Oeser (lichtwerk) on Tue, Nov 19, 12:06 PM.



Since BKE_nurb_type_convert will only ever return false if we have less
than 6 points in the curve, we can also be specific in the error

ref T71672.

Diff Detail

rB Blender
T71672 (branched from master)
Build Status
Buildable 5721
Build 5721: arc lint + arc unit

Event Timeline

While this change is OK, I think it would be better if this was set by the function it's self.

BKE_nurb_type_convert could take and optional const char **r_err_msg, and assign this in the case of an error.

This means if it ever returns false for another reason - it's less likely a developer doesn't notice the error needs updating elsewhere, or if we want to report the message elsewhere - we don't need to copy/paste messages about.