Page MenuHome

Sculpt/Paint: Remove Unified SIZE_PRESSURE and ALPHA_PRESSURE
ClosedPublic

Authored by Pablo Dobarro (pablodp606) on Fri, Nov 22, 7:38 PM.

Details

Summary

The relation between the pressure/size and the pressure/alpha is a
fundamental property that defines the behavior of a brush, so it does
not make sense to have it unified across all brushes. This applies both
for sculpting and painting.

Some of the new 2.82 brushes need pressure/size or pressure/alpha to be
enabled to work propely, while others don't. Users should not be
switching on and off this property manually when changing brushes if they
want to use unified size. This is also causing that some users are using
the brushes with an incorrect configuration.

Other solution could be add another flag to split UNIFIED_SIZE and
UNIFIED_SIZE_PRESSURE, but I don't think it is worth to add more options
to the UI now as a new brush input system that will handle all these
properties in a more configurable way is planned.

Diff Detail

Repository
rB Blender

Event Timeline

Jeroen Bakker (jbakker) requested changes to this revision.EditedTue, Nov 26, 3:33 PM
  • missing migration code?
  • missing defaults?
  • What is the reason to keep size and strength unified, but the toggle not?
source/blender/blenkernel/intern/brush.c
1402

remove the scene parameter as it is not needed anymore.

1407

remove the scene parameter as it is not needed anymore.

This revision now requires changes to proceed.Tue, Nov 26, 3:33 PM
Pablo Dobarro (pablodp606) marked 2 inline comments as done.
  • Review update

What is the reason to keep size and strength unified, but the toggle not?

Because you change the brush size in relation to the size of the artwork or the size of the detail you are trying to make. The relation of pressure and size is a property of the brush that defines its use case. I think we should not do more UI changes to the current brush input code, but that toggle should not be there, it should be under the stroke or brush popover. To have all the required functionality, not only this toggle should be stored per brush, but also the curve that maps pressure and size should be stored per brush (that is what I'm currently doing for sculpt mode, but it is not editable).

This revision is now accepted and ready to land.Wed, Nov 27, 9:00 AM