Sculpt/Paint: Remove Unified SIZE_PRESSURE and ALPHA_PRESSURE
ClosedPublic
Actions

Authored by Pablo Dobarro (pablodp606) on Fri, Nov 22, 7:38 PM.

Details

Reviewers

Commits

rB9251b077203c: Sculpt/Paint: Remove Unified SIZE_PRESSURE and ALPHA_PRESSURE

Summary

The relation between the pressure/size and the pressure/alpha is a
fundamental property that defines the behavior of a brush, so it does
not make sense to have it unified across all brushes. This applies both
for sculpting and painting.

Some of the new 2.82 brushes need pressure/size or pressure/alpha to be
enabled to work propely, while others don't. Users should not be
switching on and off this property manually when changing brushes if they
want to use unified size. This is also causing that some users are using
the brushes with an incorrect configuration.

Other solution could be add another flag to split UNIFIED_SIZE and
UNIFIED_SIZE_PRESSURE, but I don't think it is worth to add more options
to the UI now as a new brush input system that will handle all these
properties in a more configurable way is planned.

Diff Detail

Repository: rB Blender

Event Timeline

Pablo Dobarro (pablodp606) created this revision.Fri, Nov 22, 7:38 PM

Harbormaster completed remote builds in B5754: Diff 19789.Fri, Nov 22, 7:39 PM

Pablo Dobarro (pablodp606) added a reviewer: Jeroen Bakker (jbakker).Fri, Nov 22, 7:39 PM

Pablo Dobarro (pablodp606) added a project: BF Blender (2.82).

Metin Seven (MetinSeven) awarded a token.Sun, Nov 24, 7:56 PM

missing migration code?
missing defaults?
What is the reason to keep size and strength unified, but the toggle not?

source/blender/blenkernel/intern/brush.c
1402	remove the `scene` parameter as it is not needed anymore.
1407	remove the `scene` parameter as it is not needed anymore.

This revision now requires changes to proceed.Tue, Nov 26, 3:33 PM

Review update

Harbormaster completed remote builds in B5786: Diff 19852.Wed, Nov 27, 1:58 AM

What is the reason to keep size and strength unified, but the toggle not?

Because you change the brush size in relation to the size of the artwork or the size of the detail you are trying to make. The relation of pressure and size is a property of the brush that defines its use case. I think we should not do more UI changes to the current brush input code, but that toggle should not be there, it should be under the stroke or brush popover. To have all the required functionality, not only this toggle should be stored per brush, but also the curve that maps pressure and size should be stored per brush (that is what I'm currently doing for sculpt mode, but it is not editable).

Jeroen Bakker (jbakker) accepted this revision.Wed, Nov 27, 9:00 AM

This revision is now accepted and ready to land.Wed, Nov 27, 9:00 AM

Closed by commit rB9251b077203c: Sculpt/Paint: Remove Unified SIZE_PRESSURE and ALPHA_PRESSURE (authored by Pablo Dobarro (pablodp606)). · Explain WhyWed, Nov 27, 5:15 PM

This revision was automatically updated to reflect the committed changes.

Pablo Dobarro (pablodp606) added a commit: rB9251b077203c: Sculpt/Paint: Remove Unified SIZE_PRESSURE and ALPHA_PRESSURE.

Revision Contents
Changeset List

			Path	Packages
M			release/scripts/startup/bl_ui/properties_paint_common.py (16 lines)
M			source/blender/blenkernel/BKE_brush.h (4 lines)
M			source/blender/blenkernel/intern/brush.c (14 lines)
M			source/blender/blenloader/intern/versioning_280.c (8 lines)
M			source/blender/editors/sculpt_paint/paint_cursor.c (11 lines)
M			source/blender/editors/sculpt_paint/paint_image.c (2 lines)
M			source/blender/editors/sculpt_paint/paint_stroke.c (12 lines)
M			source/blender/editors/sculpt_paint/paint_vertex.c (8 lines)
M			source/blender/editors/sculpt_paint/sculpt.c (7 lines)
M			source/blender/makesdna/DNA_scene_types.h (9 lines)
M			source/blender/makesrna/intern/rna_scene.c (11 lines)

Diff	ID	Base	Description	Created	Lint	Unit
Base			Base
Diff 1	19789	71ddcf1		Fri, Nov 22, 7:38 PM	★	★
Diff 2	19852	7af5604	- Review update	Wed, Nov 27, 1:58 AM	★	★
Diff 3	19906	0e4014e	rB9251b077203c763f1be83505ed0a4d1e19dab947	Wed, Nov 27, 5:17 PM	★	★