Add panning to circle select
AbandonedPublic
Actions

Authored by Valentin (Poulpator) on Wed, Nov 27, 6:56 AM.

Details

Reviewers

Campbell Barton (campbellbarton)
William Reynish (billreynish)

Summary

this patch add panning like in the knife operator which allow to move,rotate and zoom while using the circle select operator in various editor(view3d, uv, node, etc..).

summary of the patch:

Middle mouse move the view instead of deselect which is already handle with click+shift.
Change Add/Subtract size of brush with Ctrl + wheelmouse instead of just wheelmouse. I originaly did the patch only for move/rotate the view tell me if this change is okay.
wheelmouse up/down zoom the view

Diff Detail

Event Timeline

Valentin (Poulpator) created this revision.Wed, Nov 27, 6:56 AM

fix preprocessor error with else statement

This is more a design task than a patch.

For Blender 2.5x we chose to use the current design and not allow view operations with circle select.
This is inconsistent with circle select tool deselect.
Middle mouse is still used for box select, if changed, we may want to change this too.

I'd prefer to leave this as-is, users who want to circle select and navigate can use the circle select tool.

Leaving code review out of this reply.

Campbell Barton (campbellbarton) mentioned this in T63726: User Interface Module .Wed, Nov 27, 8:29 AM

Well, I didn't know about the circle select tool, but this patch can still be useful, not everyone is used to tools(even at blender studio), and tutorials still use brush select.
Morevover brush select provide shortcut to increase the size of the brush unlike to the circle select tool.

This is inconsistent with circle select tool deselect.

Already inconsistent today

Middle mouse is still used for box select, if changed, we may want to change this too.

Agreed

Giuseppe Bufalo (Peps) awarded a token.Thu, Nov 28, 11:56 AM

Talked to others in the UI team about this.

Closing this patch since it exposes too many limits in the keymap and modal operator system.

We don't have a good way to make events fall though and be caught only by view operators, meaning every modal operator needs to duplicate view operations.
It's not a big enough improvement to justify a change for users who are experienced w/ the current keymap.
It introduced inconsistency with box select.

Revision Contents
Changeset List

			Path	Packages
M			release/scripts/presets/keyconfig/keymap_data/blender_default.py (7 lines)
M			source/blender/windowmanager/WM_types.h (2 lines)
M			source/blender/windowmanager/intern/wm_gesture.c (4 lines)
M			source/blender/windowmanager/intern/wm_gesture_ops.c (32 lines)
M			source/blender/windowmanager/intern/wm_operators.c (2 lines)
M			source/blender/windowmanager/wm_event_types.h (23 lines)