Page MenuHome

Fix T71000: Scene statistics dont take collections hidden state into account
AbandonedPublic

Authored by Philipp Oeser (lichtwerk) on Wed, Nov 27, 2:03 PM.

Details

Summary

Caused by rB0812949bbc3d.

Shouldnt we take viewlayer visibility into account in
BKE_object_visibility as well if we are evaluating for the viewport?

Diff Detail

Repository
rB Blender
Branch
T71000 (branched from master)
Build Status
Buildable 5806
Build 5806: arc lint + arc unit

Event Timeline

If this is having unwanted sideeffects as well, then workaround is to exclude the collection [checkmark], instead of hiding for the viewport [eye icon]...

Dalai Felinto (dfelinto) requested changes to this revision.Wed, Nov 27, 2:43 PM

I agree that the bug is legit-ish. However this patch breaks local collections altogether. Big no, sorry.

The actual fix would be to loop over the editors in the active window and check for local collections, ... not worth in my opinion. It may even have a performance impact if not done right. It can be done with a single object loop though. Maybe I can look at that.

This revision now requires changes to proceed.Wed, Nov 27, 2:43 PM

Yeah, was pretty sure this would have sideeffects.
Now these sideeffects were pretty much 'in your face' [sorry for not checking beforehand].

Would suggest to just abandon this, mind claiming T71000: Scene statistics dont take hidden state into account (2.80 did) then?