Page MenuHome

GPencil: Add Opacity y Onion switch to Dopesheet
ClosedPublic

Authored by Antonio Vazquez (antoniov) on Fri, Nov 29, 10:15 AM.

Details

Summary

Add new icons and panels Grease Pencil Dopesheet to manage layers without having the properties panel visible.

Also, the icons are in the same order in Dopesheet, Layers and Material list to keep consistency.

As the number of columns for icons is limited to 3 and we also need use a factor, I have impleted the change using slider area. Also, the slider option is enabled by default for 2D Template.

See T72026 for more info.

Note: I would like to include this in 2.82 version

Diff Detail

Repository
rB Blender

Event Timeline

Matias Mendiola (mendio) requested changes to this revision.Fri, Nov 29, 12:52 PM

Everything works well, just one minor change for UI consistency:
Switch visible and lock buttons order in the layer and material panels in properties editor to follow the left-right/top-bottom order we are using.

This revision now requires changes to proceed.Fri, Nov 29, 12:52 PM
  • GPencil: Switch lock icons to keep UI consistency
This revision is now accepted and ready to land.Fri, Nov 29, 4:13 PM

I can see why this makes sense - consolidates the layer controls together more.

Seems overall OK I think.

Yes, improve a lot the animation workflow

I do have some objections regarding the design, posted these in T72026.
Basically I'd like to know if alternatives were considered, and why this solution was chosen, which has the trade-off that it doesn't scale well if we want to give quick access to more options.

I agree we cannot add more and more controls to the Dopesheet, but this is not the case here. If you look at the screen below, you will see we just added the same icons we had in Layers panels since the beginning. We tried to add to Dopesheet these icons since the beginning, but due lack of time we didn't change it until now.

For adding new properties, I have added the N panel to the right. Here is where we can add more and more properties, but never to the dopesheet or it would be a mess. To have the Opacity, Blend and Onion icons only is was a decision after testing a lot the tool and ask a lot of people about workflow in 2D animation, and with these tools, we improve a lot the workflow, so we don't need any more, but at the same time we cannot remove any icon neither. This is the minimum and maximum set of properties we need. If someone wants more, then will go to the side panel only.

Other option would be to have side panel only, but then we miss the easy way to have a "full" view of all your layers, because side panel is only active layer, so you need select one by one to see how is defined or close your Brush panels to make space to open Layers panel in the Properties panel.

I can see why it makes sense to put these controls in the Dopesheet sidebar - it mirrors more what we do in the NLA and Sequencer, and brings things together more.

But, to me it's then not very clear why thet also must still be in the Properties editor then. To me it seems fairly redundant to duplicate these controls twice - if they make more sense in the Dopesheet, we could just move them there fully.

The idea is that the main workflow to deal with layers is in dopesheet and use the properties panel for brushes and vertex colors (see a possible startup proposal pic).


but many times you are dealing with a lot of layers (30/40 layers or more) and the properties panel is so usefull for a quick layer management without lost drawing area.

@Daniel Martinez Lara (pepeland) yes but is it really necessary to also keep these layer controls in the Properties editor, as well as the Dopesheet? That, to me, is the main question.

@Daniel Martinez Lara (pepeland) yes but is it really necessary to also keep these layer controls in the Properties editor, as well as the Dopesheet? That, to me, is the main question.

The answer to that question IMO is that they are not strictly necessary in the Dopesheet but could be really helpful in many cases, for example when using 2D Full Canvas workspace without a properties editor.
The essential controls are those in the header (Opacity, Blend, Onion, visibility, lock, etc).

The only layer parameters directly related to the Dopesheet channels are actually: 'Custom Channel Color' and 'Show Only on Keyframed', in case we decide not to have all layers settings on the Dopesheet sidebar we can keep those properties at least.

What is the final decision here? We need move to master before December 12th or it will be in next release, so, you decide.

IMO the dopesheet is the main and and natutal area to deal with channels and have it in the properties too basically is sooo useful for many cases and workflows

Is the same reason like this example, just because is handy have this options in diferent places for diferent workflows

keep it it works that way very well if it is in prop area.

IMO the dopesheet is the main and and natutal area to deal with channels and have it in the properties too basically is sooo useful for many cases and workflows
Is the same reason like this example, just because is handy have this options in diferent places for diferent workflows

I agree that keep the settings on both panels is the best option, they help different user workflows like just use Grease Pencil for Drawing or animating.

I think this is probably acceptable, overall.

One small thing: Is there a strong reason why the layout isn't 100% identical between Properties and the Dopesheet? The Display panel isn't the Dopesheet, and the contents of it is moved elsewhere. As I see it, might as well do it the same both places.

  • Move Display options to its own subpanel
  • Create Parent Class to share python code

@William Reynish (billreynish) I have fixed the display panel and now both (Dopesheet & Properties) panels are equals. Also, I have created a Parent class to share the code and avoid duplications and reduce maintenace complexity.

Antonio Vazquez (antoniov) edited the summary of this revision. (Show Details)
  • Fix memory leak in Sliders