Page MenuHome

Fix T72130: Wireframe Visible After Disabling
ClosedPublic

Authored by Jeroen Bakker (jbakker) on Tue, Dec 3, 8:34 AM.

Details

Summary

The lines index buffer can contain all edges (edit mode) or only loose
edges (object mode). When switching between these modes the wrong
content of the index buffer can be used.

This patch will clear the lines index buffer when a loose_edges is requested. Making sure it is always up to date.

Note that this is supporting an exising hack where the IBO is truncated
during the creation. We should find a different way how to solve these
kind of issues.

Diff Detail

Repository
rB Blender

Event Timeline

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)Tue, Dec 3, 8:43 AM

@Clément Foucault (fclem) just a sanity check that this won't break other logic.

This is not correct. The bug comes from the fact that DRW_cache_mesh_loose_edges_get is incorrect and still contains the whole mesh in some case. It's an issue in the batch cache.

Jeroen Bakker (jbakker) planned changes to this revision.Tue, Dec 3, 11:30 AM

Ok, will check there. might be an invalidate issue

Jeroen Bakker (jbakker) edited the summary of this revision. (Show Details)Tue, Dec 3, 3:19 PM

cleared the ibo.lines when requesting the loose_edges batch

[WIP] add a lines_loose ibo

Jeroen Bakker (jbakker) planned changes to this revision.Tue, Dec 3, 4:46 PM

Still some regressions.

This revision is now accepted and ready to land.Wed, Dec 4, 12:58 PM