Page MenuHome

Fix T40921: Gravity in walk mode hard-coded, cannot use alternate scene scale
ClosedPublic

Authored by Dalai Felinto (dfelinto) on Jul 7 2014, 5:48 PM.

Diff Detail

Event Timeline

@Campbell Barton (campbellbarton) what do you think? Another option is to have the gravity in the UI and use it when scene.physics_settings.use_gravity == False.

I think you can commit this one, Dalai. Changes are fairly simple and straightforward. Just a minor comment below. :)

source/blender/editors/space_view3d/view3d_walk.c
515

should be fabsf.

Do not see any 'Fix T40925: Scene gravity hard limited' though ;)

I find a bit obscure that the gravity is either EARTH_GRAVITY or scene gravity. One of the reasons I brought up to review is to wonder if we should explicitly have the gravity value in the UI. Let's wait until Monday to see if Campbell drops by.

Dalai Felinto (dfelinto) updated this revision to Unknown Object (????).Jul 11 2014, 3:50 PM
  • fabs -> fabsf

Well, tbh I do not see the point in adding another gravity setting, we already have one… Imho good doc explaining that is enough. :)

PS: Campbell is supposed to be on holidays, which means he tend to flee tracker… ;)

Ah I didn't know that. In this case I'm committing it, we can always change it once he is back.