Page MenuHome

Fix T72690: Do not draw points behind the viewport camera in the paint cursor
AcceptedPublic

Authored by Pablo Dobarro (pablodp606) on Dec 26 2019, 11:32 PM.

Details

Summary

In some situations the symmetry point may be behind the camera, so the
projection is inverted and it looks wrong. This avoids drawing points in
screen space when they are behind the camera.

Diff Detail

Repository
rB Blender
Branch
T72690 (branched from master)
Build Status
Buildable 6371
Build 6371: arc lint + arc unit

Event Timeline

Jeroen Bakker (jbakker) requested changes to this revision.Mon, Dec 30, 4:49 PM
Jeroen Bakker (jbakker) added inline comments.
source/blender/editors/sculpt_paint/paint_cursor.c
1107

Should we use minimum clipping distance?

This revision now requires changes to proceed.Mon, Dec 30, 4:49 PM
source/blender/editors/sculpt_paint/paint_cursor.c
1107

How can that be used here?

Brecht Van Lommel (brecht) added inline comments.
source/blender/editors/sculpt_paint/paint_cursor.c
1107

ED_view3d_project uses the OpenGL projection matrix, which remaps Z from [near, far] to [-1, 1]. So this test actually uses the near clipping distance and seems correct, though a comment would help to explain it.

Pablo Dobarro (pablodp606) marked 2 inline comments as done.
  • Add comment
This revision is now accepted and ready to land.Tue, Jan 28, 12:59 PM